| Message ID | 006001ceaec2$f0ef0dd0$d2cd2970$%han@samsung.com |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
On Wed, 2013-09-11 at 16:45 +0900, Jingoo Han wrote: > The driver core clears the driver data to NULL after device_release > or on probe failure. Thus, it is not needed to manually clear the > device driver data to NULL. > > Signed-off-by: Jingoo Han <jg1.han@samsung.com> > --- > drivers/net/ethernet/intel/e100.c | 2 -- > 1 file changed, 2 deletions(-) While I do not find anything wrong with this patch, I personally like good housekeeping so I would like to keep the code as is. Is there a reason for this patch?
On Wednesday, September 11, 2013 5:40 PM, Jeff Kirsher wrote: > On Wed, 2013-09-11 at 16:45 +0900, Jingoo Han wrote: > > The driver core clears the driver data to NULL after device_release > > or on probe failure. Thus, it is not needed to manually clear the > > device driver data to NULL. > > > > Signed-off-by: Jingoo Han <jg1.han@samsung.com> > > --- > > drivers/net/ethernet/intel/e100.c | 2 -- > > 1 file changed, 2 deletions(-) > > While I do not find anything wrong with this patch, I personally like > good housekeeping so I would like to keep the code as is. Is there a > reason for this patch? Vice versa, Is there any reason to keep unnecessary code? Clearing drvdata is done by driver core, so each driver does not need to clear drvdata. This patch reduces code size and removes duplicated functional execution. Please consider it positively. :-) Best regards, Jingoo Han -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/ethernet/intel/e100.c b/drivers/net/ethernet/intel/e100.c index ada6e21..cbaba44 100644 --- a/drivers/net/ethernet/intel/e100.c +++ b/drivers/net/ethernet/intel/e100.c @@ -2985,7 +2985,6 @@ err_out_free_res: err_out_disable_pdev: pci_disable_device(pdev); err_out_free_dev: - pci_set_drvdata(pdev, NULL); free_netdev(netdev); return err; } @@ -3003,7 +3002,6 @@ static void e100_remove(struct pci_dev *pdev) free_netdev(netdev); pci_release_regions(pdev); pci_disable_device(pdev); - pci_set_drvdata(pdev, NULL); } }
The driver core clears the driver data to NULL after device_release or on probe failure. Thus, it is not needed to manually clear the device driver data to NULL. Signed-off-by: Jingoo Han <jg1.han@samsung.com> --- drivers/net/ethernet/intel/e100.c | 2 -- 1 file changed, 2 deletions(-)