diff mbox

bug[#43]: kgdboe: netpoll: Should handle ETH_P_ARP other than ETH_P_IP in netpoll_neigh_reply

Message ID 1378870313-14161-1-git-send-email-sonic.adi@gmail.com
State Accepted, archived
Delegated to: David Miller
Headers show

Commit Message

Sonic Zhang Sept. 11, 2013, 3:31 a.m. UTC 
From: Sonic Zhang <sonic.zhang@analog.com>

The received ARP request type in the Ethernet packet head is ETH_P_ARP other than ETH_P_IP.

Signed-off-by: Sonic Zhang <sonic.zhang@analog.com>
---
 net/core/netpoll.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

David Miller Sept. 12, 2013, 9:17 p.m. UTC | #1 
From: Sonic Zhang <sonic.adi@gmail.com>
Date: Wed, 11 Sep 2013 11:31:53 +0800

> From: Sonic Zhang <sonic.zhang@analog.com>
> 
> The received ARP request type in the Ethernet packet head is ETH_P_ARP other than ETH_P_IP.
> 
> Signed-off-by: Sonic Zhang <sonic.zhang@analog.com>

This bug was introduced by commit b7394d2429c198b1da3d46ac39192e891029ec0f
("netpoll: prepare for ipv6")

I'll apply this, thank you.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/net/core/netpoll.c b/net/core/netpoll.c
index 2c637e9..c3c7b27 100644
--- a/net/core/netpoll.c
+++ b/net/core/netpoll.c
@@ -550,7 +550,7 @@  static void netpoll_neigh_reply(struct sk_buff *skb, struct netpoll_info *npinfo
 		return;
 
 	proto = ntohs(eth_hdr(skb)->h_proto);
-	if (proto == ETH_P_IP) {
+	if (proto == ETH_P_ARP) {
 		struct arphdr *arp;
 		unsigned char *arp_ptr;
 		/* No arp on this interface */