| Message ID | 1378850315-22371-1-git-send-email-bluemrp9@gmail.com |
|---|---|
| State | Rejected |
| Headers | show |
Dear Ryan Coe, On Tue, 10 Sep 2013 14:58:35 -0700, Ryan Coe wrote: > $(TARGET_MAKE_ENV) $(MAKE1) $(LINUX_MAKE_FLAGS) -C $(@D) \ > - DEPMOD="$(HOST_DIR)/usr/sbin/depmod" modules_install ; \ > + DEPMOD="$(HOST_DIR)/sbin/depmod" modules_install ; \ Not sure why we have to pass DEPMOD here since it's already part of LINUX_MAKE_FLAGS. Am I missing something? Thomas
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes: Thomas> Dear Ryan Coe, Thomas> On Tue, 10 Sep 2013 14:58:35 -0700, Ryan Coe wrote: >> $(TARGET_MAKE_ENV) $(MAKE1) $(LINUX_MAKE_FLAGS) -C $(@D) \ >> - DEPMOD="$(HOST_DIR)/usr/sbin/depmod" modules_install ; \ >> + DEPMOD="$(HOST_DIR)/sbin/depmod" modules_install ; \ Thomas> Not sure why we have to pass DEPMOD here since it's already part of Thomas> LINUX_MAKE_FLAGS. Am I missing something? No, I think you're right. I've removed it in git. Thanks.
On 09/11/2013 04:23 AM, Peter Korsgaard wrote: >>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> writes: > > Thomas> Dear Ryan Coe, > Thomas> On Tue, 10 Sep 2013 14:58:35 -0700, Ryan Coe wrote: > >> $(TARGET_MAKE_ENV) $(MAKE1) $(LINUX_MAKE_FLAGS) -C $(@D) \ > >> - DEPMOD="$(HOST_DIR)/usr/sbin/depmod" modules_install ; \ > >> + DEPMOD="$(HOST_DIR)/sbin/depmod" modules_install ; \ > > Thomas> Not sure why we have to pass DEPMOD here since it's already part of > Thomas> LINUX_MAKE_FLAGS. Am I missing something? > > No, I think you're right. I've removed it in git. > > Thanks. > Without the depmod in the target install, I do not get the necessary files installed to the target. I am unable to load modules until I manually run depmod -a.
>>>>> "Ryan" == Ryan Coe <bluemrp9@gmail.com> writes:
Hi,
Ryan> Without the depmod in the target install, I do not get the necessary
Ryan> files installed to the target. I am unable to load modules until I
Ryan> manually run depmod -a.
Really? LINUX_MAKE_FLAGS expands to .. DEPMOD=$(HOST_DIR)/sbin/depmod,
so we ended up passing 2x DEPMOD= to modules_install.
On 09/11/2013 07:23 AM, Ryan Coe wrote: > > I will try it without the second instance and report back. > > On Sep 11, 2013 7:20 AM, "Peter Korsgaard" <jacmet@uclibc.org > <mailto:jacmet@uclibc.org>> wrote: > > >>>>> "Ryan" == Ryan Coe <bluemrp9@gmail.com > <mailto:bluemrp9@gmail.com>> writes: > > Hi, > > Ryan> Without the depmod in the target install, I do not get the > necessary > Ryan> files installed to the target. I am unable to load modules > until I > Ryan> manually run depmod -a. > > Really? LINUX_MAKE_FLAGS expands to .. DEPMOD=$(HOST_DIR)/sbin/depmod, > so we ended up passing 2x DEPMOD= to modules_install. > > -- > Bye, Peter Korsgaard > I can confirm that this does work. The second time that depmod was passed was causing trouble.
diff --git a/linux/linux.mk b/linux/linux.mk index 649d06b..1650143 100644 --- a/linux/linux.mk +++ b/linux/linux.mk @@ -274,7 +274,7 @@ define LINUX_INSTALL_TARGET_CMDS # directories, not relevant on the target @if grep -q "CONFIG_MODULES=y" $(@D)/.config; then \ $(TARGET_MAKE_ENV) $(MAKE1) $(LINUX_MAKE_FLAGS) -C $(@D) \ - DEPMOD="$(HOST_DIR)/usr/sbin/depmod" modules_install ; \ + DEPMOD="$(HOST_DIR)/sbin/depmod" modules_install ; \ rm -f $(TARGET_DIR)/lib/modules/$(LINUX_VERSION_PROBED)/build ; \ rm -f $(TARGET_DIR)/lib/modules/$(LINUX_VERSION_PROBED)/source ; \ fi
Signed-off-by: Ryan Coe <bluemrp9@gmail.com> --- linux/linux.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)