Patchwork A Bug: xserver_xorg 1.12.4

login
register
mail settings
Submitter Woody Wu
Date Sept. 9, 2013, 8:04 a.m.
Message ID <20130909080432.GA2684@zuhnb712.ap.bm.net>
Download mbox | patch
Permalink /patch/273963/
State Superseded
Headers show

Comments

Woody Wu - Sept. 9, 2013, 8:04 a.m.
In 2013.08, build is using 1.12.4 version of xserver_xorg package.
However, I found there is bug in this version, which cause the options
parsing of kdrive modules is not correct.

I attached a patch file in the message (not sure what's the correct way
to commit buildroot package patches).
Thomas Petazzoni - Sept. 11, 2013, 9:17 a.m.
Dear Woody Wu,

On Mon, 9 Sep 2013 16:04:33 +0800, Woody Wu wrote:
> In 2013.08, build is using 1.12.4 version of xserver_xorg package.
> However, I found there is bug in this version, which cause the options
> parsing of kdrive modules is not correct.
> 
> I attached a patch file in the message (not sure what's the correct way
> to commit buildroot package patches).

Unfortunately, no, it's not the correct. You should submit a patch
against Buildroot, which adds a patch in
package/x11r7/xserver_xorg-server/ that fixes the bug you're seeing.

See http://buildroot.org/downloads/manual/manual.html#patch-policy.

Also, it'd be good to see if this patch has been fixed upstream
already. If it's already fixed upstream, either backport the upstream
patch, or bump the X.org server version used in Buildroot. If not, then
try to submit your patch upstream so that it gets integrated in future
releases of X.org.

Thanks,

Thomas
Peter Korsgaard - Sept. 11, 2013, 10:52 a.m.
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:

 Thomas> Dear Woody Wu,
 Thomas> On Mon, 9 Sep 2013 16:04:33 +0800, Woody Wu wrote:
 >> In 2013.08, build is using 1.12.4 version of xserver_xorg package.
 >> However, I found there is bug in this version, which cause the options
 >> parsing of kdrive modules is not correct.
 >> 
 >> I attached a patch file in the message (not sure what's the correct way
 >> to commit buildroot package patches).

 Thomas> Unfortunately, no, it's not the correct. You should submit a patch
 Thomas> against Buildroot, which adds a patch in
 Thomas> package/x11r7/xserver_xorg-server/ that fixes the bug you're seeing.

 Thomas> See http://buildroot.org/downloads/manual/manual.html#patch-policy.

 Thomas> Also, it'd be good to see if this patch has been fixed upstream
 Thomas> already. If it's already fixed upstream, either backport the upstream
 Thomas> patch, or bump the X.org server version used in Buildroot. If not, then
 Thomas> try to submit your patch upstream so that it gets integrated in future
 Thomas> releases of X.org.

It is fixed upstream, but it was never pushed to the 1.12 branch:

http://cgit.freedesktop.org/xorg/xserver/commit/hw/kdrive/src/kinput.c?id=09f1e5b15b769e1122f0a8d7

I've cherry picked it and added it to buildroot, thanks.

Patch

--- a/hw/kdrive/src/kinput.c	2012-08-19 23:41:37.000000000 +0800
+++ b/hw/kdrive/src/kinput.c	2013-09-09 15:52:26.353042088 +0800
@@ -1055,7 +1055,7 @@ 
 
     if (strchr(string, '=')) {
         tam_key = (strchr(string, '=') - string);
-        key = strndup(string, tam_key + 1);
+        key = strndup(string, tam_key);
         if (!key)
             goto out;