diff mbox

vsftpd: Fix dependency for needs mmu

Message ID 1378534043.18257.3.camel@phoenix
State Accepted
Commit 5cad4bd403bf672a55585cfb610abe7b19596003
Headers show

Commit Message

Axel Lin Sept. 7, 2013, 6:07 a.m. UTC 
Commit 2eb995759 "vsftpd: needs mmu" adds "depends on BR2_TOOLCHAIN_HAS_THREADS".

The build error is:
sysutil.c:(.text+0x37ac): undefined reference to `fork'

Thus it should depend on BR2_USE_MMU rather than BR2_TOOLCHAIN_HAS_THREADS.

Cc: Gustavo Zacarias <gustavo@zacarias.com.ar>
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
 package/vsftpd/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Peter Korsgaard Sept. 11, 2013, 10:58 a.m. UTC | #1 
>>>>> "Axel" == Axel Lin <axel.lin@ingics.com> writes:

 Axel> Commit 2eb995759 "vsftpd: needs mmu" adds "depends on BR2_TOOLCHAIN_HAS_THREADS".
 Axel> The build error is:
 Axel> sysutil.c:(.text+0x37ac): undefined reference to `fork'

 Axel> Thus it should depend on BR2_USE_MMU rather than BR2_TOOLCHAIN_HAS_THREADS.

Indeed:

grep -rls pthread output/build/vsftpd-3.0.2/

grep -rls fork output/build/vsftpd-3.0.2/
output/build/vsftpd-3.0.2/Changelog
output/build/vsftpd-3.0.2/SPEED
output/build/vsftpd-3.0.2/sysdeputil.h
output/build/vsftpd-3.0.2/ssl.c
output/build/vsftpd-3.0.2/ptracesandbox.c
output/build/vsftpd-3.0.2/twoprocess.c
output/build/vsftpd-3.0.2/postprivparent.c
output/build/vsftpd-3.0.2/sysutil.h
output/build/vsftpd-3.0.2/SECURITY/TRUST
output/build/vsftpd-3.0.2/standalone.c
output/build/vsftpd-3.0.2/sysdeputil.c
output/build/vsftpd-3.0.2/sysutil.c

Committed, thanks.
diff mbox

Patch

diff --git a/package/vsftpd/Config.in b/package/vsftpd/Config.in
index 3d4cff1..54ef7bd 100644
--- a/package/vsftpd/Config.in
+++ b/package/vsftpd/Config.in
@@ -1,6 +1,6 @@ 
 config BR2_PACKAGE_VSFTPD
 	bool "vsftpd"
-	depends on BR2_TOOLCHAIN_HAS_THREADS # fork()
+	depends on BR2_USE_MMU # fork()
 	help
 	  vsftpd is an ftp daemon written with security in mind.
 	  http://vsftpd.beasts.org/