| Message ID | 1378831135-2179-1-git-send-email-murzin.v@gmail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
On 09/10/2013 10:08 PM, Vladimir Murzin wrote: > While cross-building for PPC64 I've got > Vladimir, Below commit ID fixes this issue. commit 256588fda10f2a712631f8a4e72641a66adebdb8 Author: Guenter Roeck <linux@roeck-us.net> Date: Mon Sep 9 18:37:56 2013 -0700 powerpc: Export cpu_to_chip_id() to fix build error -Vasant > ERROR: ".cpu_to_chip_id" [drivers/block/mtip32xx/mtip32xx.ko] undefined! > > mtip32xx refer to topology_physical_package_id, which stands for > cpu_to_chip-id. > > Make cpu_to_chip-id (and topology_physical_package_id) available for > external users. > > Signed-off-by: Vladimir Murzin <murzin.v@gmail.com> > --- > arch/powerpc/kernel/smp.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/powerpc/kernel/smp.c b/arch/powerpc/kernel/smp.c > index 442d8e2..1d9c1c2 100644 > --- a/arch/powerpc/kernel/smp.c > +++ b/arch/powerpc/kernel/smp.c > @@ -611,6 +611,7 @@ int cpu_to_chip_id(int cpu) > of_node_put(np); > return of_get_ibm_chip_id(np); > } > +EXPORT_SYMBOL_GPL(cpu_to_chip_id); > > /* Helper routines for cpu to core mapping */ > int cpu_core_index_of_thread(int cpu) >
On Wed, Sep 11, 2013 at 12:07:45PM +0530, Vasant Hegde wrote: > On 09/10/2013 10:08 PM, Vladimir Murzin wrote: > > While cross-building for PPC64 I've got > > > Vladimir, > > Below commit ID fixes this issue. Great! For whatever reason I thought _GPL is default policy for exported symbols... but, never mind ;) Sorry for the noise Vladimir > > commit 256588fda10f2a712631f8a4e72641a66adebdb8 > Author: Guenter Roeck <linux@roeck-us.net> > Date: Mon Sep 9 18:37:56 2013 -0700 > > powerpc: Export cpu_to_chip_id() to fix build error > > -Vasant > > > ERROR: ".cpu_to_chip_id" [drivers/block/mtip32xx/mtip32xx.ko] undefined! > > > > mtip32xx refer to topology_physical_package_id, which stands for > > cpu_to_chip-id. > > > > Make cpu_to_chip-id (and topology_physical_package_id) available for > > external users. > > > > Signed-off-by: Vladimir Murzin <murzin.v@gmail.com> > > --- > > arch/powerpc/kernel/smp.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/arch/powerpc/kernel/smp.c b/arch/powerpc/kernel/smp.c > > index 442d8e2..1d9c1c2 100644 > > --- a/arch/powerpc/kernel/smp.c > > +++ b/arch/powerpc/kernel/smp.c > > @@ -611,6 +611,7 @@ int cpu_to_chip_id(int cpu) > > of_node_put(np); > > return of_get_ibm_chip_id(np); > > } > > +EXPORT_SYMBOL_GPL(cpu_to_chip_id); > > > > /* Helper routines for cpu to core mapping */ > > int cpu_core_index_of_thread(int cpu) > > >
diff --git a/arch/powerpc/kernel/smp.c b/arch/powerpc/kernel/smp.c index 442d8e2..1d9c1c2 100644 --- a/arch/powerpc/kernel/smp.c +++ b/arch/powerpc/kernel/smp.c @@ -611,6 +611,7 @@ int cpu_to_chip_id(int cpu) of_node_put(np); return of_get_ibm_chip_id(np); } +EXPORT_SYMBOL_GPL(cpu_to_chip_id); /* Helper routines for cpu to core mapping */ int cpu_core_index_of_thread(int cpu)
While cross-building for PPC64 I've got ERROR: ".cpu_to_chip_id" [drivers/block/mtip32xx/mtip32xx.ko] undefined! mtip32xx refer to topology_physical_package_id, which stands for cpu_to_chip-id. Make cpu_to_chip-id (and topology_physical_package_id) available for external users. Signed-off-by: Vladimir Murzin <murzin.v@gmail.com> --- arch/powerpc/kernel/smp.c | 1 + 1 file changed, 1 insertion(+)