Patchwork [1/4] usb: sanity check setup_index+setup_len in post_load

login
register
mail settings
Submitter Gerd Hoffmann
Date Sept. 10, 2013, 9:41 a.m.
Message ID <1378806073-25197-2-git-send-email-kraxel@redhat.com>
Download mbox | patch
Permalink /patch/273801/
State New
Headers show

Comments

Gerd Hoffmann - Sept. 10, 2013, 9:41 a.m.
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 hw/usb/bus.c | 4 ++++
 1 file changed, 4 insertions(+)

Patch

diff --git a/hw/usb/bus.c b/hw/usb/bus.c
index 82ca6a1..72d5b92 100644
--- a/hw/usb/bus.c
+++ b/hw/usb/bus.c
@@ -47,6 +47,10 @@  static int usb_device_post_load(void *opaque, int version_id)
     } else {
         dev->attached = 1;
     }
+    if (dev->setup_index >= sizeof(dev->data_buf) ||
+        dev->setup_len >= sizeof(dev->data_buf)) {
+        return -EINVAL;
+    }
     return 0;
 }