Message ID | 1378798960-6572-1-git-send-email-sachin.kamat@linaro.org |
---|---|
State | Deferred, archived |
Delegated to: | David Miller |
Headers | show |
> -----Original Message----- > From: netdev-owner@vger.kernel.org [mailto:netdev- > owner@vger.kernel.org] On Behalf Of Sachin Kamat > Sent: Tuesday, September 10, 2013 9:43 AM > To: netdev@vger.kernel.org > Cc: davem@davemloft.net; Eilon Greenstein; sachin.kamat@linaro.org > Subject: [PATCH 1/1] net: bnx2x: Staticize local symbols > > Local symbols used only in this file are made static. > > Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> > --- > drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c > b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c > index 2604b62..5ec30cc 100644 > --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c > +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c > @@ -2802,7 +2802,7 @@ struct set_vf_state_cookie { > u8 state; > }; > > -void bnx2x_set_vf_state(void *cookie) > +static void bnx2x_set_vf_state(void *cookie) > { > struct set_vf_state_cookie *p = (struct set_vf_state_cookie > *)cookie; > > @@ -3222,7 +3222,8 @@ void bnx2x_disable_sriov(struct bnx2x *bp) > pci_disable_sriov(bp->pdev); > } > > -int bnx2x_vf_ndo_prep(struct bnx2x *bp, int vfidx, struct bnx2x_virtf **vf, > +static int I don't like this form. Better to put the last variable in the next line. > +bnx2x_vf_ndo_prep(struct bnx2x *bp, int vfidx, struct bnx2x_virtf **vf, > struct pf_vf_bulletin_content **bulletin) > { > if (bp->state != BNX2X_STATE_OPEN) { > -- > 1.7.9.5 > > -- > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html Thanks for suggesting the fix. Not sure this is appropriate for net though... Ariel -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 10 September 2013 13:53, Ariel Elior <ariele@broadcom.com> wrote: >> -----Original Message----- >> From: netdev-owner@vger.kernel.org [mailto:netdev- >> owner@vger.kernel.org] On Behalf Of Sachin Kamat >> Sent: Tuesday, September 10, 2013 9:43 AM >> To: netdev@vger.kernel.org >> Cc: davem@davemloft.net; Eilon Greenstein; sachin.kamat@linaro.org >> Subject: [PATCH 1/1] net: bnx2x: Staticize local symbols >> >> -int bnx2x_vf_ndo_prep(struct bnx2x *bp, int vfidx, struct bnx2x_virtf **vf, >> +static int > I don't like this form. Better to put the last variable in the next line. OK. Will change it. > > Thanks for suggesting the fix. > Not sure this is appropriate for net though... Sorry, did not get this. Please elaborate.
diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c index 2604b62..5ec30cc 100644 --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c @@ -2802,7 +2802,7 @@ struct set_vf_state_cookie { u8 state; }; -void bnx2x_set_vf_state(void *cookie) +static void bnx2x_set_vf_state(void *cookie) { struct set_vf_state_cookie *p = (struct set_vf_state_cookie *)cookie; @@ -3222,7 +3222,8 @@ void bnx2x_disable_sriov(struct bnx2x *bp) pci_disable_sriov(bp->pdev); } -int bnx2x_vf_ndo_prep(struct bnx2x *bp, int vfidx, struct bnx2x_virtf **vf, +static int +bnx2x_vf_ndo_prep(struct bnx2x *bp, int vfidx, struct bnx2x_virtf **vf, struct pf_vf_bulletin_content **bulletin) { if (bp->state != BNX2X_STATE_OPEN) {
Local symbols used only in this file are made static. Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> --- drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)