Patchwork bc47xx : export ssb_watchdog_timer_set

login
register
mail settings
Submitter matthieu castet
Date May 18, 2009, 10:10 p.m.
Message ID <4A11DCBF.9000700@free.fr>
Download mbox | patch
Permalink /patch/27377/
State Not Applicable
Headers show

Comments

matthieu castet - May 18, 2009, 10:10 p.m.
Hi,

this patch export ssb_watchdog_timer_set to allow to use it in a Linux 
watchdog driver.


Signed-off-by: Matthieu CASTET <castet.matthieu@free.fr>
John W. Linville - May 18, 2009, 10:41 p.m.
On Tue, May 19, 2009 at 12:10:07AM +0200, matthieu castet wrote:
> Hi,
>
> this patch export ssb_watchdog_timer_set to allow to use it in a Linux  
> watchdog driver.
>
>
> Signed-off-by: Matthieu CASTET <castet.matthieu@free.fr>

What is the merge path for ssb nowadays?  I used to take these patches
(and I'm still happy to do so), but maybe Ralf is (or should be)
taking them now?

John
Michael Buesch - May 19, 2009, 1:22 p.m.
On Tuesday 19 May 2009 00:10:07 matthieu castet wrote:
> Hi,
> 
> this patch export ssb_watchdog_timer_set to allow to use it in a Linux 
> watchdog driver.
> 
> 
> Signed-off-by: Matthieu CASTET <castet.matthieu@free.fr>

Well, you need to be careful. The watchdog is also used for system reboot.
Make sure to disable the watchdog driver when the bcm47xx system code wants
to use it.

Otherwise, ack. You can submit this to linville@tuxdriver.com.
Michael Buesch - May 19, 2009, 1:24 p.m.
On Tuesday 19 May 2009 00:41:28 John W. Linville wrote:
> On Tue, May 19, 2009 at 12:10:07AM +0200, matthieu castet wrote:
> > Hi,
> >
> > this patch export ssb_watchdog_timer_set to allow to use it in a Linux  
> > watchdog driver.
> >
> >
> > Signed-off-by: Matthieu CASTET <castet.matthieu@free.fr>
> 
> What is the merge path for ssb nowadays?  I used to take these patches
> (and I'm still happy to do so), but maybe Ralf is (or should be)
> taking them now?

That depends on his speed. Last time I submitted a patch through his path,
it bitrotted for several months before it finally hit mainline.
Ralf Baechle - May 19, 2009, 5:09 p.m.
On Tue, May 19, 2009 at 03:24:20PM +0200, Michael Buesch wrote:

> > What is the merge path for ssb nowadays?  I used to take these patches
> > (and I'm still happy to do so), but maybe Ralf is (or should be)
> > taking them now?
> 
> That depends on his speed. Last time I submitted a patch through his path,
> it bitrotted for several months before it finally hit mainline.

Maybe because I felt drivers/ssb/ was outside my jurisdiction - and unlike
what alot of people may seem to think I'm not a full time MIPS kernel
hacker.

I can deal with SSB patch if you so desire - but I have no experience with
SSB, so I'd have somebody to rubberstamp non-trivial SSB patches before I
queue them up.  I can keep them either in the usual MIPS trees on
linux-mips.org or I could create a separate linux-ssb tree, depending on
what seems to be sensible.  Also, reading the entry in the maintainers
file I wonder if netdev is really the list of a choice?

  Ralf
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Michael Buesch - May 19, 2009, 5:29 p.m.
On Tuesday 19 May 2009 19:09:57 Ralf Baechle wrote:
> Maybe because I felt drivers/ssb/ was outside my jurisdiction - and unlike
> what alot of people may seem to think I'm not a full time MIPS kernel
> hacker.

Ok nice.

> I can deal with SSB patch if you so desire - but I have no experience with
> SSB, so I'd have somebody to rubberstamp non-trivial SSB patches before I
> queue them up.

 **Fwoo..
[stamp here]
      ..mppp**


Done. :)

> I can keep them either in the usual MIPS trees on 
> linux-mips.org or I could create a separate linux-ssb tree, depending on
> what seems to be sensible.  Also, reading the entry in the maintainers
> file I wonder if netdev is really the list of a choice?

Yes it is, because the bus is only used on networking devices.
(Ethernet cards, wireless cards, and network routers)
I don't think you need to create a separate tree. ssb is pretty mature. There
won't be that many patches.
John W. Linville - May 19, 2009, 5:35 p.m.
On Tue, May 19, 2009 at 07:29:20PM +0200, Michael Buesch wrote:
> On Tuesday 19 May 2009 19:09:57 Ralf Baechle wrote:
> > Maybe because I felt drivers/ssb/ was outside my jurisdiction - and unlike
> > what alot of people may seem to think I'm not a full time MIPS kernel
> > hacker.
> 
> Ok nice.
> 
> > I can deal with SSB patch if you so desire - but I have no experience with
> > SSB, so I'd have somebody to rubberstamp non-trivial SSB patches before I
> > queue them up.
> 
>  **Fwoo..
> [stamp here]
>       ..mppp**
> 
> 
> Done. :)
> 
> > I can keep them either in the usual MIPS trees on 
> > linux-mips.org or I could create a separate linux-ssb tree, depending on
> > what seems to be sensible.  Also, reading the entry in the maintainers
> > file I wonder if netdev is really the list of a choice?
> 
> Yes it is, because the bus is only used on networking devices.
> (Ethernet cards, wireless cards, and network routers)
> I don't think you need to create a separate tree. ssb is pretty mature. There
> won't be that many patches.

OK, now I'm confused again -- should I take SSB patches, or is Ralf
going to do it? :-)

John
Ralf Baechle - May 20, 2009, 7:15 a.m.
On Tue, May 19, 2009 at 01:35:03PM -0400, John W. Linville wrote:
> From: "John W. Linville" <linville@tuxdriver.com>
> Date: Tue, 19 May 2009 13:35:03 -0400
> To: Michael Buesch <mb@bu3sch.de>
> Cc: Ralf Baechle <ralf@linux-mips.org>,
> 	matthieu castet <castet.matthieu@free.fr>,
> 	linux-mips@linux-mips.org, netdev@vger.kernel.org
> Subject: Re: [PATCH] bc47xx : export ssb_watchdog_timer_set
> Content-Type: text/plain; charset=us-ascii
> 
> On Tue, May 19, 2009 at 07:29:20PM +0200, Michael Buesch wrote:
> > On Tuesday 19 May 2009 19:09:57 Ralf Baechle wrote:
> > > Maybe because I felt drivers/ssb/ was outside my jurisdiction - and unlike
> > > what alot of people may seem to think I'm not a full time MIPS kernel
> > > hacker.
> > 
> > Ok nice.
> > 
> > > I can deal with SSB patch if you so desire - but I have no experience with
> > > SSB, so I'd have somebody to rubberstamp non-trivial SSB patches before I
> > > queue them up.
> > 
> >  **Fwoo..
> > [stamp here]
> >       ..mppp**
> > 
> > 
> > Done. :)
> > 
> > > I can keep them either in the usual MIPS trees on 
> > > linux-mips.org or I could create a separate linux-ssb tree, depending on
> > > what seems to be sensible.  Also, reading the entry in the maintainers
> > > file I wonder if netdev is really the list of a choice?
> > 
> > Yes it is, because the bus is only used on networking devices.
> > (Ethernet cards, wireless cards, and network routers)
> > I don't think you need to create a separate tree. ssb is pretty mature. There
> > won't be that many patches.
> 
> OK, now I'm confused again -- should I take SSB patches, or is Ralf
> going to do it? :-)

My decoder ring says, I'll do it from now on :)

Cheers,

  Ralf
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
John W. Linville - May 20, 2009, 12:57 p.m.
On Wed, May 20, 2009 at 08:15:13AM +0100, Ralf Baechle wrote:
> On Tue, May 19, 2009 at 01:35:03PM -0400, John W. Linville wrote:

> > OK, now I'm confused again -- should I take SSB patches, or is Ralf
> > going to do it? :-)
> 
> My decoder ring says, I'll do it from now on :)

ACK
Michael Buesch - May 20, 2009, 1:49 p.m.
On Wednesday 20 May 2009 09:15:13 Ralf Baechle wrote:
> On Tue, May 19, 2009 at 01:35:03PM -0400, John W. Linville wrote:
> > From: "John W. Linville" <linville@tuxdriver.com>
> > Date: Tue, 19 May 2009 13:35:03 -0400
> > To: Michael Buesch <mb@bu3sch.de>
> > Cc: Ralf Baechle <ralf@linux-mips.org>,
> > 	matthieu castet <castet.matthieu@free.fr>,
> > 	linux-mips@linux-mips.org, netdev@vger.kernel.org
> > Subject: Re: [PATCH] bc47xx : export ssb_watchdog_timer_set
> > Content-Type: text/plain; charset=us-ascii
> > 
> > On Tue, May 19, 2009 at 07:29:20PM +0200, Michael Buesch wrote:
> > > On Tuesday 19 May 2009 19:09:57 Ralf Baechle wrote:
> > > > Maybe because I felt drivers/ssb/ was outside my jurisdiction - and unlike
> > > > what alot of people may seem to think I'm not a full time MIPS kernel
> > > > hacker.
> > > 
> > > Ok nice.
> > > 
> > > > I can deal with SSB patch if you so desire - but I have no experience with
> > > > SSB, so I'd have somebody to rubberstamp non-trivial SSB patches before I
> > > > queue them up.
> > > 
> > >  **Fwoo..
> > > [stamp here]
> > >       ..mppp**
> > > 
> > > 
> > > Done. :)
> > > 
> > > > I can keep them either in the usual MIPS trees on 
> > > > linux-mips.org or I could create a separate linux-ssb tree, depending on
> > > > what seems to be sensible.  Also, reading the entry in the maintainers
> > > > file I wonder if netdev is really the list of a choice?
> > > 
> > > Yes it is, because the bus is only used on networking devices.
> > > (Ethernet cards, wireless cards, and network routers)
> > > I don't think you need to create a separate tree. ssb is pretty mature. There
> > > won't be that many patches.
> > 
> > OK, now I'm confused again -- should I take SSB patches, or is Ralf
> > going to do it? :-)
> 
> My decoder ring says, I'll do it from now on :)


Ok, nice. :)
Matthieu, can you resend them to Ralf? He doesn't have them, yet.
matthieu castet - May 21, 2009, 10:39 a.m.
Michael Buesch wrote:
> On Tuesday 19 May 2009 00:10:07 matthieu castet wrote:
>> Hi,
>>
>> this patch export ssb_watchdog_timer_set to allow to use it in a Linux 
>> watchdog driver.
>>
>>
>> Signed-off-by: Matthieu CASTET <castet.matthieu@free.fr>
> 
> Well, you need to be careful. The watchdog is also used for system reboot.
> Make sure to disable the watchdog driver when the bcm47xx system code wants
> to use it.
> 
It shouldn't be a problem : the system code always disable irq before 
using watchdog to reboot/halt (unless I miss other watchdog usage).

Matthieu
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
matthieu castet - May 21, 2009, 10:45 a.m.
Hi,

Michael Buesch wrote:
> On Wednesday 20 May 2009 09:15:13 Ralf Baechle wrote:
> 
> 
> Ok, nice. :)
> Matthieu, can you resend them to Ralf? He doesn't have them, yet.
> 
Off course.

BTW what's the procedure for submitting patch on mips ?
I already CC linux-mips, on the first patch submission.
Now that it is acked by maintainer, I should resend it to linux-mips + 
Ralf ?


Thanks

Matthieu
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/ssb/embedded.c b/drivers/ssb/embedded.c
index 7dc3a6b..a0e0d24 100644
--- a/drivers/ssb/embedded.c
+++ b/drivers/ssb/embedded.c
@@ -29,6 +29,7 @@  int ssb_watchdog_timer_set(struct ssb_bus *bus, u32 ticks)
 	}
 	return -ENODEV;
 }
+EXPORT_SYMBOL(ssb_watchdog_timer_set);
 
 u32 ssb_gpio_in(struct ssb_bus *bus, u32 mask)
 {