| Message ID | 1378777076-4699-1-git-send-email-linux@roeck-us.net (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
On Mon, 2013-09-09 at 18:37 -0700, Guenter Roeck wrote: > powerpc allmodconfig build fails with: > > ERROR: ".cpu_to_chip_id" [drivers/block/mtip32xx/mtip32xx.ko] undefined! > > The problem was introduced with commit 15863ff3b (powerpc: Make chip-id > information available to userspace). Thanks, I'll send that to Linus asap. Ben. > Export the missing symbol. > > Cc: Vasant Hegde <hegdevasant@linux.vnet.ibm.com> > Cc: Shivaprasad G Bhat <sbhat@linux.vnet.ibm.com> > Signed-off-by: Guenter Roeck <linux@roeck-us.net> > --- > arch/powerpc/kernel/smp.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/powerpc/kernel/smp.c b/arch/powerpc/kernel/smp.c > index 442d8e2..8e59abc 100644 > --- a/arch/powerpc/kernel/smp.c > +++ b/arch/powerpc/kernel/smp.c > @@ -611,6 +611,7 @@ int cpu_to_chip_id(int cpu) > of_node_put(np); > return of_get_ibm_chip_id(np); > } > +EXPORT_SYMBOL(cpu_to_chip_id); > > /* Helper routines for cpu to core mapping */ > int cpu_core_index_of_thread(int cpu)
On 09/11/2013 03:33 AM, Benjamin Herrenschmidt wrote: > On Mon, 2013-09-09 at 18:37 -0700, Guenter Roeck wrote: >> powerpc allmodconfig build fails with: >> >> ERROR: ".cpu_to_chip_id" [drivers/block/mtip32xx/mtip32xx.ko] undefined! >> >> The problem was introduced with commit 15863ff3b (powerpc: Make chip-id >> information available to userspace). > > Thanks, I'll send that to Linus asap. > Verified on today's Linus tree. This issue is fixed. Thanks a lot. -Vasant > Ben. > >> Export the missing symbol. >> >> Cc: Vasant Hegde <hegdevasant@linux.vnet.ibm.com> >> Cc: Shivaprasad G Bhat <sbhat@linux.vnet.ibm.com> >> Signed-off-by: Guenter Roeck <linux@roeck-us.net> >> --- >> arch/powerpc/kernel/smp.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/arch/powerpc/kernel/smp.c b/arch/powerpc/kernel/smp.c >> index 442d8e2..8e59abc 100644 >> --- a/arch/powerpc/kernel/smp.c >> +++ b/arch/powerpc/kernel/smp.c >> @@ -611,6 +611,7 @@ int cpu_to_chip_id(int cpu) >> of_node_put(np); >> return of_get_ibm_chip_id(np); >> } >> +EXPORT_SYMBOL(cpu_to_chip_id); >> >> /* Helper routines for cpu to core mapping */ >> int cpu_core_index_of_thread(int cpu) > > > _______________________________________________ > Linuxppc-dev mailing list > Linuxppc-dev@lists.ozlabs.org > https://lists.ozlabs.org/listinfo/linuxppc-dev >
diff --git a/arch/powerpc/kernel/smp.c b/arch/powerpc/kernel/smp.c index 442d8e2..8e59abc 100644 --- a/arch/powerpc/kernel/smp.c +++ b/arch/powerpc/kernel/smp.c @@ -611,6 +611,7 @@ int cpu_to_chip_id(int cpu) of_node_put(np); return of_get_ibm_chip_id(np); } +EXPORT_SYMBOL(cpu_to_chip_id); /* Helper routines for cpu to core mapping */ int cpu_core_index_of_thread(int cpu)
powerpc allmodconfig build fails with: ERROR: ".cpu_to_chip_id" [drivers/block/mtip32xx/mtip32xx.ko] undefined! The problem was introduced with commit 15863ff3b (powerpc: Make chip-id information available to userspace). Export the missing symbol. Cc: Vasant Hegde <hegdevasant@linux.vnet.ibm.com> Cc: Shivaprasad G Bhat <sbhat@linux.vnet.ibm.com> Signed-off-by: Guenter Roeck <linux@roeck-us.net> --- arch/powerpc/kernel/smp.c | 1 + 1 file changed, 1 insertion(+)