Patchwork [1/7] lspci: Label PCIe LnkCap "L0s Exit Latency" as "L0s", not "L0"

login
register
mail settings
Submitter Bjorn Helgaas
Date Sept. 9, 2013, 11:13 p.m.
Message ID <20130909231345.30095.61638.stgit@bhelgaas-glaptop>
Download mbox | patch
Permalink /patch/273718/
State Not Applicable
Headers show

Comments

Bjorn Helgaas - Sept. 9, 2013, 11:13 p.m.
The PCIe Link Capabilities "L0s Exit Latency" is the latency to exit
L0s, not L0, so label it "L0s" instead of "L0".  This matches the
way we label the Device Capabilities "Endpoint L0s Acceptable Latency"
field as "Latency L0s".  This also adds "Exit" to the description to
help distinguish it from the "Acceptable Latency" fields in the
Device Capabilities register.

Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
---
 ls-caps.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Martin Mares - Nov. 10, 2013, 11:33 a.m.
Hi!

> The PCIe Link Capabilities "L0s Exit Latency" is the latency to exit
> L0s, not L0, so label it "L0s" instead of "L0".  This matches the
> way we label the Device Capabilities "Endpoint L0s Acceptable Latency"
> field as "Latency L0s".  This also adds "Exit" to the description to
> help distinguish it from the "Acceptable Latency" fields in the
> Device Capabilities register.

Applied the whole patch set.

				Have a nice fortnight

Patch

diff --git a/ls-caps.c b/ls-caps.c
index be19d38..a1a1546 100644
--- a/ls-caps.c
+++ b/ls-caps.c
@@ -753,7 +753,7 @@  static void cap_express_link(struct device *d, int where, int type)
   u16 w;
 
   t = get_conf_long(d, where + PCI_EXP_LNKCAP);
-  printf("\t\tLnkCap:\tPort #%d, Speed %s, Width x%d, ASPM %s, Latency L0 %s, L1 %s\n",
+  printf("\t\tLnkCap:\tPort #%d, Speed %s, Width x%d, ASPM %s, Exit Latency L0s %s, L1 %s\n",
 	t >> 24,
 	link_speed(t & PCI_EXP_LNKCAP_SPEED), (t & PCI_EXP_LNKCAP_WIDTH) >> 4,
 	aspm_support((t & PCI_EXP_LNKCAP_ASPM) >> 10),