From patchwork Mon Sep 9 16:56:08 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chris Healy X-Patchwork-Id: 273620 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id D54872C0121 for ; Tue, 10 Sep 2013 02:56:35 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754898Ab3IIQ4c (ORCPT ); Mon, 9 Sep 2013 12:56:32 -0400 Received: from mail-oa0-f48.google.com ([209.85.219.48]:40258 "EHLO mail-oa0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751113Ab3IIQ4b (ORCPT ); Mon, 9 Sep 2013 12:56:31 -0400 Received: by mail-oa0-f48.google.com with SMTP id o17so6554521oag.7 for ; Mon, 09 Sep 2013 09:56:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=E+ZbUXDPlKx856IfAW4rnb3ZSuiaQiim9SnY5UwXRbk=; b=tuHdMNJPDg6uYL2Xu1syLEnnNYme+1XLTisRfG23C6MHmrUkSGz4vyv3rkgKFHOAJ0 06OXvjyY6ndtBDvcAbxwnYFUHEMw8TFox9+2CDVk1b009XMzPkilgSFYA49kbcihY0fJ 7OAJCoLmJEpgXuFDE8JMM+OpcoHz3VYyqJeavOMLUyi+JuMIs17wYDjJ+uC0x+69uyKa HSwqh/VPz3IvDXH5k1Oc6V3fbMocMpeL32/BR+IJdQ6b5nsd7fwg3YL+2KYHPWGx9H24 EAX/fWyL0bHXn59/DnL/kgIB+hQX2IRb7/cla0uQ3Og2jhkRsG7LdBKjRVZVp4LwMxMF LvJg== X-Received: by 10.60.132.178 with SMTP id ov18mr4635160oeb.39.1378745791064; Mon, 09 Sep 2013 09:56:31 -0700 (PDT) Received: from cphealy-desktop.gateway.2wire.net (99-73-211-50.lightspeed.irvnca.sbcglobal.net. [99.73.211.50]) by mx.google.com with ESMTPSA id r6sm13558489obi.14.1969.12.31.16.00.00 (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 09 Sep 2013 09:56:30 -0700 (PDT) From: Chris Healy To: Stephen Hemminger , "David S. Miller" Cc: bridge@lists.linux-foundation.org, netdev@vger.kernel.org, buytenh@wantstofly.org, Chris Healy Subject: [PATCH 1/1] bridge: fix message_age_timer calculation Date: Mon, 9 Sep 2013 09:56:08 -0700 Message-Id: <1378745768-4495-1-git-send-email-cphealy@gmail.com> X-Mailer: git-send-email 1.8.1.2 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This changes the message_age_timer calculation to use the BPDU's max age as opposed to the local bridge's max age. This is in accordance with section 8.6.2.3.2 Step 2 of the 802.1D-1998 sprecification. With the current implementation, when running with very large bridge diameters, convergance will not always occur even if a root bridge is configured to have a longer max age. Tested successfully on bridge diameters of ~200. Signed-off-by: Chris Healy Acked-by: Stephen Hemminger --- net/bridge/br_stp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/bridge/br_stp.c b/net/bridge/br_stp.c index 1c0a50f..f1887ba 100644 --- a/net/bridge/br_stp.c +++ b/net/bridge/br_stp.c @@ -209,7 +209,7 @@ static void br_record_config_information(struct net_bridge_port *p, p->designated_age = jiffies - bpdu->message_age; mod_timer(&p->message_age_timer, jiffies - + (p->br->max_age - bpdu->message_age)); + + (bpdu->max_age - bpdu->message_age)); } /* called under bridge lock */