From patchwork Fri Sep 6 21:28:10 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Behan Webster X-Patchwork-Id: 273337 Return-Path: X-Original-To: incoming-imx@patchwork.ozlabs.org Delivered-To: patchwork-incoming-imx@bilbo.ozlabs.org Received: from casper.infradead.org (unknown [IPv6:2001:770:15f::2]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 4096E2C0107 for ; Sat, 7 Sep 2013 07:32:44 +1000 (EST) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1VI3d0-0008Og-OD; Fri, 06 Sep 2013 21:31:43 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1VI3cn-0000ap-2d; Fri, 06 Sep 2013 21:31:29 +0000 Received: from mail-ie0-x22f.google.com ([2607:f8b0:4001:c03::22f]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1VI3cl-0000Ys-7Q for linux-arm-kernel@lists.infradead.org; Fri, 06 Sep 2013 21:31:27 +0000 Received: by mail-ie0-f175.google.com with SMTP id u16so7755078iet.6 for ; Fri, 06 Sep 2013 14:31:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=converseincode.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; bh=wbSyK4YVZLwk9KA1ok6oGAsihXSGc6XD2VYa/MspU9I=; b=BP+CoZn9oyVUOjzdLKVJNXnl6dIBA0M7YGyYamGgW/doaJopdu0QMkNt1dEtS0/iPE aoRGjatEZHzVPMrIzN0kpZ5GZJa/a54oM+uzqGidvxEsHaMIUE/KF6jIwdfGKrD9npCr 9XkpcEY2Puwy/IyS16Bm9f52Pv0bsswPnb+qM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-type:content-transfer-encoding; bh=wbSyK4YVZLwk9KA1ok6oGAsihXSGc6XD2VYa/MspU9I=; b=St7R8Wxt4WRYBY2BfibO/BKmtRNyb5SCDH6+AlQ8wobjdhOluJL84fzXT3CNKn6wDN yo/xrKRoguJyGdX6VCYg5HPWddnd1NLnW/cXgPGJTyNDITvcd7nraq/EKYf/XTkscj5y f+pHBU1qKHpvU0h4zg74/Ob9w9qN5TCtE5ZKJeIjoGedHrmCeCS0YvuEE06j4GcE9ifm ivnw2eRVssH+84qrd4XmTymdX2cUeRNsW6TsxyLAgbolYZZY17AGxrUJzMrhtLkMCFg8 fW+aVoPXvHHxjrrjz8Y0q8YfjLQilP82TfIxPGp1Zax+uGs0glWObiJuue73Nst0Rjfl /YGg== X-Gm-Message-State: ALoCoQnA29PG18hCI7KEXltcPRUNvy/fMqa3KEDglQx70m0DTVO5v25kXkNu0mAJctYzswLf5XfH X-Received: by 10.42.54.132 with SMTP id r4mr2814018icg.19.1378503066686; Fri, 06 Sep 2013 14:31:06 -0700 (PDT) Received: from galdor.websterwood.com (216-58-123-51.cpe.distributel.net. [216.58.123.51]) by mx.google.com with ESMTPSA id i1sm605871iga.0.1969.12.31.16.00.00 (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 06 Sep 2013 14:31:06 -0700 (PDT) From: behanw@converseincode.com To: linux@arm.linux.org.uk Subject: [PATCH 4/5] arm: LLVMLinux: Use current_stack_pointer in save_stack_trace_tsk Date: Fri, 6 Sep 2013 17:28:10 -0400 Message-Id: <1378502899-1241-5-git-send-email-behanw@converseincode.com> X-Mailer: git-send-email 1.8.1.2 In-Reply-To: <1378502899-1241-1-git-send-email-behanw@converseincode.com> References: <1378502899-1241-1-git-send-email-behanw@converseincode.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20130906_173127_391370_9FE617AE X-CRM114-Status: GOOD ( 12.08 ) X-Spam-Score: -2.0 (--) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-2.0 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature Cc: Mark Charlebois , "moderated list:ARM PORT" , =?UTF-8?q?Jan-Simon=20M=C3=B6ller?= , open list X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org List-Id: linux-imx-kernel.lists.patchwork.ozlabs.org From: Behan Webster The existing code uses named registers to get the value of the stack pointer. The new current_stack_pointer macro is more readable and allows for a central portable implementation of how to get the stack pointer with ASM. This change supports being able to compile the kernel with both gcc and Clang. Signed-off-by: Mark Charlebois Signed-off-by: Behan Webster Reviewed-by: Jan-Simon Möller --- arch/arm/kernel/stacktrace.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/arch/arm/kernel/stacktrace.c b/arch/arm/kernel/stacktrace.c index 00f79e5..8c23310 100644 --- a/arch/arm/kernel/stacktrace.c +++ b/arch/arm/kernel/stacktrace.c @@ -109,11 +109,9 @@ void save_stack_trace_tsk(struct task_struct *tsk, struct stack_trace *trace) frame.pc = thread_saved_pc(tsk); #endif } else { - register unsigned long current_sp asm ("sp"); - data.no_sched_functions = 0; frame.fp = (unsigned long)__builtin_frame_address(0); - frame.sp = current_sp; + frame.sp = current_stack_pointer; frame.lr = (unsigned long)__builtin_return_address(0); frame.pc = (unsigned long)save_stack_trace_tsk; }