Patchwork [i386] : Turn on -fms-extensions option for i386 ms-abi targets

login
register
mail settings
Submitter Kai Tietz
Date Sept. 6, 2013, 7:21 p.m.
Message ID <CAEwic4b5NBjMgNUsuqNgZ2FLvt-4SJdErm0UBU3_SGi1=LBB-Q@mail.gmail.com>
Download mbox | patch
Permalink /patch/273322/
State New
Headers show

Comments

Kai Tietz - Sept. 6, 2013, 7:21 p.m.
Hello,

This patch changes for i386 targets using by default ms-abi the
default-value of option -fms-extensions.  For those targets the option
will be turned on.

I will apply this patch next week, if there are no objections.

Regards,
Kai

ChangeLog

2013-09-06  Kai Tietz  <ktietz@redhat.com>

    * doc/invoke.texi (fms-extensions): Document changed
    behavior for ms-abi targets.
    * config/i386/i386.c (ix86_option_override_internal):
    Set default value of option -fms-extension for ms-abi targets.

Patch

Index: doc/invoke.texi
===================================================================
--- doc/invoke.texi (Revision 202346)
+++ doc/invoke.texi (Arbeitskopie)
@@ -1856,6 +1856,8 @@  Some cases of unnamed fields in structures and uni
 accepted with this option.  @xref{Unnamed Fields,,Unnamed struct/union
 fields within structs/unions}, for details.

+Note that this option is off for all targets but i?86 and x86_64
+targets using ms-abi.
 @item -fplan9-extensions
 Accept some non-standard constructs used in Plan 9 code.
Index: config/i386/i386.c
===================================================================
--- config/i386/i386.c      (Revision 202134)
+++ config/i386/i386.c      (Arbeitskopie)
@@ -3357,6 +3357,12 @@  ix86_option_override_internal (bool main_args_p)
   if (!global_options_set.x_ix86_abi)
     ix86_abi = DEFAULT_ABI;

+  /* For targets using ms ABI enable ms-extensions, if not
+     explicit turned off.  For non-ms ABI we turn off this
+     option.  */
+  if (!global_options_set.x_flag_ms_extensions)
+    flag_ms_extensions = (MS_ABI == DEFAULT_ABI);
+
   if (global_options_set.x_ix86_cmodel)
     {
       switch (ix86_cmodel)