Patchwork [i386,AVX-512F,pr58269] Partial fix for PR58269: properly initialize last EXT REX SSE register.

login
register
mail settings
Submitter Kirill Yukhin
Date Sept. 6, 2013, 8:34 a.m.
Message ID <20130906083457.GA31758@msticlxl57.ims.intel.com>
Download mbox | patch
Permalink /patch/273121/
State New
Headers show

Comments

Kirill Yukhin - Sept. 6, 2013, 8:34 a.m.
Hello,
Here is a patch to fix pr58269.
Actually this is not a full fix, but an obvious part.

ChangeLog entry:
2013-09-06  Kirill Yukhin  <kirill.yukhin@intel.com>

	PR target/58269
	* gcc/config/i386/i386.c (ix86_conditional_register_usage):
	Proper initialize extended SSE registers.

Bootstrap pass.

Ok for trunk?

--
Thanks, K

---
 gcc/config/i386/i386.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Uros Bizjak - Sept. 6, 2013, 9:28 a.m.
On Fri, Sep 6, 2013 at 10:34 AM, Kirill Yukhin <kirill.yukhin@gmail.com> wrote:
> Hello,
> Here is a patch to fix pr58269.
> Actually this is not a full fix, but an obvious part.
>
> ChangeLog entry:
> 2013-09-06  Kirill Yukhin  <kirill.yukhin@intel.com>
>
>         PR target/58269
>         * gcc/config/i386/i386.c (ix86_conditional_register_usage):
>         Proper initialize extended SSE registers.

This is OK.

Thanks,
Uros.
Jakub Jelinek - Sept. 6, 2013, 9:29 a.m.
On Fri, Sep 06, 2013 at 11:28:53AM +0200, Uros Bizjak wrote:
> On Fri, Sep 6, 2013 at 10:34 AM, Kirill Yukhin <kirill.yukhin@gmail.com> wrote:
> > Hello,
> > Here is a patch to fix pr58269.
> > Actually this is not a full fix, but an obvious part.
> >
> > ChangeLog entry:
> > 2013-09-06  Kirill Yukhin  <kirill.yukhin@intel.com>
> >
> >         PR target/58269
> >         * gcc/config/i386/i386.c (ix86_conditional_register_usage):
> >         Proper initialize extended SSE registers.
> 
> This is OK.

But please leave out gcc/ prefix from the ChangeLog entry.

	Jakub
Kirill Yukhin - Sept. 6, 2013, 10:37 a.m.
Hello,
On 06 Sep 11:29, Jakub Jelinek wrote:
> On Fri, Sep 06, 2013 at 11:28:53AM +0200, Uros Bizjak wrote:
> > This is OK.
> 
> But please leave out gcc/ prefix from the ChangeLog entry.

Thanks, checked into main trunk: http://gcc.gnu.org/ml/gcc-cvs/2013-09/msg00181.html
with fixed ChangeLog.

--
Thanks, K

Patch

diff --git a/gcc/config/i386/i386.c b/gcc/config/i386/i386.c
index a8d70bc..d6a40a8 100644
--- a/gcc/config/i386/i386.c
+++ b/gcc/config/i386/i386.c
@@ -4218,7 +4218,7 @@  ix86_conditional_register_usage (void)
 
   /* If AVX512F is disabled, squash the registers.  */
   if (! TARGET_AVX512F)
-    for (i = FIRST_EXT_REX_SSE_REG; i < LAST_EXT_REX_SSE_REG; i++)
+    for (i = FIRST_EXT_REX_SSE_REG; i <= LAST_EXT_REX_SSE_REG; i++)
       fixed_regs[i] = call_used_regs[i] = 1, reg_names[i] = "";
 }