| Message ID | 4A0DCE67.70106@gmail.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
> FIFO1_DMA_ERR is set twice, the second should be FIFO2_DMA_ERR. > > Signed-off-by: Roel Kluin <roel.kluin@gmail.com> > --- > Correct? Please review. > > diff --git a/drivers/net/vxge/vxge-traffic.c b/drivers/net/vxge/vxge- > traffic.c > index 7be0ae1..c2eeac4 100644 > --- a/drivers/net/vxge/vxge-traffic.c > +++ b/drivers/net/vxge/vxge-traffic.c > @@ -115,7 +115,7 @@ enum vxge_hw_status vxge_hw_vpath_intr_enable(struct > __vxge_hw_vpath_handle *vp) > VXGE_HW_KDFCCTL_ERRORS_REG_KDFCCTL_FIFO1_POISON| > VXGE_HW_KDFCCTL_ERRORS_REG_KDFCCTL_FIFO2_POISON| > VXGE_HW_KDFCCTL_ERRORS_REG_KDFCCTL_FIFO1_DMA_ERR| > - VXGE_HW_KDFCCTL_ERRORS_REG_KDFCCTL_FIFO1_DMA_ERR), 0, 32), > + VXGE_HW_KDFCCTL_ERRORS_REG_KDFCCTL_FIFO2_DMA_ERR), 0, 32), > &vp_reg->kdfcctl_errors_mask); > > __vxge_hw_pio_mem_write32_upper(0, &vp_reg->vpath_ppif_int_mask); [Ram] Good catch! Acked-by: Ram Vepa <ram.vepa@neterion.com> Thanks, Ram -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: "Ramkrishna Vepa" <Ramkrishna.Vepa@neterion.com> Date: Sun, 17 May 2009 03:52:59 -0400 >> FIFO1_DMA_ERR is set twice, the second should be FIFO2_DMA_ERR. >> >> Signed-off-by: Roel Kluin <roel.kluin@gmail.com> ... > Acked-by: Ram Vepa <ram.vepa@neterion.com> Applied, thanks! -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/vxge/vxge-traffic.c b/drivers/net/vxge/vxge-traffic.c index 7be0ae1..c2eeac4 100644 --- a/drivers/net/vxge/vxge-traffic.c +++ b/drivers/net/vxge/vxge-traffic.c @@ -115,7 +115,7 @@ enum vxge_hw_status vxge_hw_vpath_intr_enable(struct __vxge_hw_vpath_handle *vp) VXGE_HW_KDFCCTL_ERRORS_REG_KDFCCTL_FIFO1_POISON| VXGE_HW_KDFCCTL_ERRORS_REG_KDFCCTL_FIFO2_POISON| VXGE_HW_KDFCCTL_ERRORS_REG_KDFCCTL_FIFO1_DMA_ERR| - VXGE_HW_KDFCCTL_ERRORS_REG_KDFCCTL_FIFO1_DMA_ERR), 0, 32), + VXGE_HW_KDFCCTL_ERRORS_REG_KDFCCTL_FIFO2_DMA_ERR), 0, 32), &vp_reg->kdfcctl_errors_mask); __vxge_hw_pio_mem_write32_upper(0, &vp_reg->vpath_ppif_int_mask);
FIFO1_DMA_ERR is set twice, the second should be FIFO2_DMA_ERR. Signed-off-by: Roel Kluin <roel.kluin@gmail.com> --- Correct? Please review. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html