Patchwork trivial: remove odd references to 'buildroot2'

login
register
mail settings
Submitter Thomas De Schampheleire
Date Sept. 5, 2013, 7:12 a.m.
Message ID <ed18f0f200351fcbb737.1378365135@argentina>
Download mbox | patch
Permalink /patch/272803/
State Accepted
Commit 6cbdfb649f8d016ead6be1d03ba5d1bf81c63e26
Headers show

Comments

Thomas De Schampheleire - Sept. 5, 2013, 7:12 a.m.
In the past there may have been a very good reason to refer to 'buildroot2', but
these days it's just odd.

Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>

---
Thomas Petazzoni - Sept. 5, 2013, 7:34 a.m.
Dear Thomas De Schampheleire,

On Thu, 05 Sep 2013 09:12:15 +0200, Thomas De Schampheleire wrote:
> In the past there may have been a very good reason to refer to 'buildroot2', but
> these days it's just odd.
> 
> Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>

Definitely-acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

Next step is obviously to rename all config options from BR2_ to BR_ :-)

Thanks!

Thomas
Thomas De Schampheleire - Sept. 5, 2013, 8:06 a.m.
On Thu, Sep 5, 2013 at 9:34 AM, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
> Dear Thomas De Schampheleire,
>
> On Thu, 05 Sep 2013 09:12:15 +0200, Thomas De Schampheleire wrote:
>> In the past there may have been a very good reason to refer to 'buildroot2', but
>> these days it's just odd.
>>
>> Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
>
> Definitely-acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
>

Thanks!

> Next step is obviously to rename all config options from BR2_ to BR_ :-)
>

Funny that you bring this up, I hadn't even made the connection!
So, does kconfig have any limit on the number of items allowed in the
legacy menu? :-D

Best regards,
Thomas
Peter Korsgaard - Sept. 5, 2013, 9:54 a.m.
>>>>> "Thomas" == Thomas De Schampheleire <patrickdepinguin+buildroot@gmail.com> writes:

 Thomas> In the past there may have been a very good reason to refer to 'buildroot2', but
 Thomas> these days it's just odd.

 Thomas> Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>

Committed, thanks.
Peter Korsgaard - Sept. 5, 2013, 9:55 a.m.
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:

 Thomas> Definitely-acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

 Thomas> Next step is obviously to rename all config options from BR2_ to BR_ :-)

Argh! ;) If we ever were to do such a thing, then I would rather simply
drop the prefix like the kernel.

Patch

diff --git a/Makefile b/Makefile
--- a/Makefile
+++ b/Makefile
@@ -1,4 +1,4 @@ 
-# Makefile for buildroot2
+# Makefile for buildroot
 #
 # Copyright (C) 1999-2005 by Erik Andersen <andersen@codepoet.org>
 # Copyright (C) 2006-2013 by the Buildroot developers <buildroot@uclibc.org>
diff --git a/support/kconfig/README.buildroot2 b/support/kconfig/README.buildroot
rename from support/kconfig/README.buildroot2
rename to support/kconfig/README.buildroot
--- a/support/kconfig/README.buildroot2
+++ b/support/kconfig/README.buildroot
@@ -4,7 +4,7 @@  to suit Buildroot.
 To update:
 	cp -r /usr/src/linux/scripts/kconfig support/kconfig.new
 	cd support/config.new
-	cp -a ../kconfig/patches ../kconfig/README.buildroot2 .
+	cp -a ../kconfig/patches ../kconfig/README.buildroot .
 	quilt push -a
 	# Fix any conflict
 	cd ..