Patchwork [3/4] targets: move target options to their own sub-menu

login
register
mail settings
Submitter Yann E. MORIN
Date Sept. 4, 2013, 9:35 p.m.
Message ID <fea6f0a0620d98f3e2971fc4f2920fd1909ae7c7.1378330371.git.yann.morin.1998@free.fr>
Download mbox | patch
Permalink /patch/272735/
State Accepted
Headers show

Comments

Yann E. MORIN - Sept. 4, 2013, 9:35 p.m.
From: "Yann E. MORIN" <yann.morin.1998@free.fr>

Currently, all target options lie in the top-level menu.
This looks a bit clumsy, since all other options are neatly
folded into their own sematic sub-menus each.

Move the target option into their own sub-menu too.

Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
---
 arch/Config.in | 4 ++++
 1 file changed, 4 insertions(+)
Thomas De Schampheleire - Sept. 5, 2013, 2:25 a.m.
Op 4-sep.-2013 23:36 schreef "Yann E. MORIN" <yann.morin.1998@free.fr> het
volgende:
>
> From: "Yann E. MORIN" <yann.morin.1998@free.fr>
>
> Currently, all target options lie in the top-level menu.
> This looks a bit clumsy, since all other options are neatly
> folded into their own sematic sub-menus each.
>
> Move the target option into their own sub-menu too.
>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>

This is an Acked-by...

> ---
>  arch/Config.in | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/arch/Config.in b/arch/Config.in
> index 14899ca..3fd8c1c 100644
> --- a/arch/Config.in
> +++ b/arch/Config.in
> @@ -1,3 +1,5 @@
> +menu "Target options"
> +
>  config BR2_ARCH_IS_64
>         bool
>
> @@ -335,3 +337,5 @@ endif
>  if BR2_xtensa
>  source "arch/Config.in.xtensa"
>  endif
> +
> +endmenu # Target options
> --
> 1.8.1.2
>
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
Peter Korsgaard - Sept. 5, 2013, 1:44 p.m.
>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:

 Yann> From: "Yann E. MORIN" <yann.morin.1998@free.fr>
 Yann> Currently, all target options lie in the top-level menu.
 Yann> This looks a bit clumsy, since all other options are neatly
 Yann> folded into their own sematic sub-menus each.

 Yann> Move the target option into their own sub-menu too.

 Yann> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
 Yann> Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>

Committed, thanks.
Yann E. MORIN - Sept. 5, 2013, 1:51 p.m.
Thomas, All,

On 2013-09-05 04:25 +0200, Thomas De Schampheleire spake thusly:
> Op 4-sep.-2013 23:36 schreef "Yann E. MORIN" <yann.morin.1998@free.fr> het
> volgende:
> >
> > From: "Yann E. MORIN" <yann.morin.1998@free.fr>
> >
> > Currently, all target options lie in the top-level menu.
> > This looks a bit clumsy, since all other options are neatly
> > folded into their own sematic sub-menus each.
> >
> > Move the target option into their own sub-menu too.
> >
> > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> > Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
> 
> This is an Acked-by...

Doh. Yes, bad cut-n-paste, sorry.

It seems I have to re-train my fingers after being away from the kbd for
15+ days... :-/

Regrads,
Yann E. MORIN.

Patch

diff --git a/arch/Config.in b/arch/Config.in
index 14899ca..3fd8c1c 100644
--- a/arch/Config.in
+++ b/arch/Config.in
@@ -1,3 +1,5 @@ 
+menu "Target options"
+
 config BR2_ARCH_IS_64
 	bool
 
@@ -335,3 +337,5 @@  endif
 if BR2_xtensa
 source "arch/Config.in.xtensa"
 endif
+
+endmenu # Target options