Patchwork [01/12] nand: docg4: use nand_base's default BBT scan

login
register
mail settings
Submitter Brian Norris
Date Sept. 4, 2013, 6:25 p.m.
Message ID <1378319126-24473-2-git-send-email-computersforpeace@gmail.com>
Download mbox | patch
Permalink /patch/272696/
State New
Headers show

Comments

Brian Norris - Sept. 4, 2013, 6:25 p.m.
There's no point in the low level driver doing the work that nand_base
already is doing; just let nand_base set the default BBT scanning
function.

Signed-off-by: Brian Norris <computersforpeace@gmail.com>
---
 drivers/mtd/nand/docg4.c | 1 -
 1 file changed, 1 deletion(-)
Mike Dunn - Sept. 5, 2013, 8:09 p.m.
On 09/04/2013 11:25 AM, Brian Norris wrote:
> There's no point in the low level driver doing the work that nand_base
> already is doing; just let nand_base set the default BBT scanning
> function.
> 
> Signed-off-by: Brian Norris <computersforpeace@gmail.com>
> ---
>  drivers/mtd/nand/docg4.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/mtd/nand/docg4.c b/drivers/mtd/nand/docg4.c
> index 548db23..7c38b8a 100644
> --- a/drivers/mtd/nand/docg4.c
> +++ b/drivers/mtd/nand/docg4.c
> @@ -1239,7 +1239,6 @@ static void __init init_mtd_structs(struct mtd_info *mtd)
>  	nand->block_markbad = docg4_block_markbad;
>  	nand->read_buf = docg4_read_buf;
>  	nand->write_buf = docg4_write_buf16;
> -	nand->scan_bbt = nand_default_bbt;
>  	nand->erase_cmd = docg4_erase_block;
>  	nand->ecc.read_page = docg4_read_page;
>  	nand->ecc.write_page = docg4_write_page;
> 

Acked-by: Mike Dunn <mikedunn@newsguy.com>

Not sure why I explicitly set that.  Thanks!

Patch

diff --git a/drivers/mtd/nand/docg4.c b/drivers/mtd/nand/docg4.c
index 548db23..7c38b8a 100644
--- a/drivers/mtd/nand/docg4.c
+++ b/drivers/mtd/nand/docg4.c
@@ -1239,7 +1239,6 @@  static void __init init_mtd_structs(struct mtd_info *mtd)
 	nand->block_markbad = docg4_block_markbad;
 	nand->read_buf = docg4_read_buf;
 	nand->write_buf = docg4_write_buf16;
-	nand->scan_bbt = nand_default_bbt;
 	nand->erase_cmd = docg4_erase_block;
 	nand->ecc.read_page = docg4_read_page;
 	nand->ecc.write_page = docg4_write_page;