[U-Boot,1/2] ARM: tegra: support SKU b1 of Tegra30

Submitted by Alban Bedel on Sept. 4, 2013, 1 p.m.

Details

Message ID 1378299618-29799-1-git-send-email-alban.bedel@avionic-design.de
State Changes Requested
Delegated to: Tom Warren
Headers show

Commit Message

Alban Bedel Sept. 4, 2013, 1 p.m.
Add the Tegra30 SKU b1 and treat it like other Tegra30 chips.

Signed-off-by: Alban Bedel <alban.bedel@avionic-design.de>
Reviewed-by: Julian Scheel <julian.scheel@avionic-design.de>
---
 arch/arm/cpu/tegra-common/ap.c          | 1 +
 arch/arm/include/asm/arch-tegra/tegra.h | 1 +
 2 files changed, 2 insertions(+)

Comments

Stephen Warren Sept. 4, 2013, 5:59 p.m.
On 09/04/2013 07:00 AM, Alban Bedel wrote:
> Add the Tegra30 SKU b1 and treat it like other Tegra30 chips.

CC'ing the Tegra maintainer would be helpful (Tom Warren; I CC'd him here)

> diff --git a/arch/arm/cpu/tegra-common/ap.c b/arch/arm/cpu/tegra-common/ap.c

> @@ -71,6 +71,7 @@ int tegra_get_chip_sku(void)
>  		switch (sku_id) {
>  		case SKU_ID_T33:
>  		case SKU_ID_T30:
> +		case SKU_ID_T30MQS:

Where does the name "T30MQS" come from? Tom, can you verify what we call
the SKUs internally?
Thierry Reding Sept. 20, 2013, 12:45 p.m.
On Wed, Sep 04, 2013 at 11:59:44AM -0600, Stephen Warren wrote:
> On 09/04/2013 07:00 AM, Alban Bedel wrote:
> > Add the Tegra30 SKU b1 and treat it like other Tegra30 chips.
> 
> CC'ing the Tegra maintainer would be helpful (Tom Warren; I CC'd him here)
> 
> > diff --git a/arch/arm/cpu/tegra-common/ap.c b/arch/arm/cpu/tegra-common/ap.c
> 
> > @@ -71,6 +71,7 @@ int tegra_get_chip_sku(void)
> >  		switch (sku_id) {
> >  		case SKU_ID_T33:
> >  		case SKU_ID_T30:
> > +		case SKU_ID_T30MQS:
> 
> Where does the name "T30MQS" come from? Tom, can you verify what we call
> the SKUs internally?

It seems like this is indeed called T30MQS internally. Actually it's
called TM30MQS-A3. I can provide an internal reference if required.

Thierry
Stephen Warren Sept. 20, 2013, 4:03 p.m.
On 09/20/2013 06:45 AM, Thierry Reding wrote:
> On Wed, Sep 04, 2013 at 11:59:44AM -0600, Stephen Warren wrote:
>> On 09/04/2013 07:00 AM, Alban Bedel wrote:
>>> Add the Tegra30 SKU b1 and treat it like other Tegra30 chips.
>> 
>> CC'ing the Tegra maintainer would be helpful (Tom Warren; I CC'd
>> him here)
>> 
>>> diff --git a/arch/arm/cpu/tegra-common/ap.c
>>> b/arch/arm/cpu/tegra-common/ap.c
>> 
>>> @@ -71,6 +71,7 @@ int tegra_get_chip_sku(void) switch (sku_id)
>>> { case SKU_ID_T33: case SKU_ID_T30: +		case SKU_ID_T30MQS:
>> 
>> Where does the name "T30MQS" come from? Tom, can you verify what
>> we call the SKUs internally?
> 
> It seems like this is indeed called T30MQS internally. Actually
> it's called TM30MQS-A3. I can provide an internal reference if
> required.

As long as it's been checked, I don't think we need to document it. In
which case, IIRC, the patch was fine.
Alban Bedel Sept. 23, 2013, 8:51 a.m.
On Fri, 20 Sep 2013 10:57:42 -0700
Tom Warren <TWarren@nvidia.com> wrote:

> Alban,
> 
> Were you going to do a V2 of this patchset? 

I expected to, but up to now there was no concrete change request.
Should I split the PMU stuff to its own mini driver, or is it
acceptable as is for now?

Alban
Alban Bedel Oct. 17, 2013, 9:29 a.m.
On Mon, 23 Sep 2013 17:23:12 -0700
Tom Warren <TWarren@nvidia.com> wrote:

> It's fine as-is for now. Send a V2 with any changes Stephen, et al requested
> (if any), and I'll get it into tegra-next when I return from vacation
> next Monday (assuming it's been Acked).

What is the status with this patch serie? I'd really like to get it
merged during this window if possible.

Alban
Thierry Reding Oct. 17, 2013, 10:50 a.m.
On Thu, Oct 17, 2013 at 11:29:06AM +0200, Alban Bedel wrote:
> On Mon, 23 Sep 2013 17:23:12 -0700
> Tom Warren <TWarren@nvidia.com> wrote:
> 
> > It's fine as-is for now. Send a V2 with any changes Stephen, et al requested
> > (if any), and I'll get it into tegra-next when I return from vacation
> > next Monday (assuming it's been Acked).
> 
> What is the status with this patch serie? I'd really like to get it
> merged during this window if possible.

One of the comments was that the SKU is internally listed as TM30MQS-A3,
not TM30MQS. I assume Tom was expecting you to spin a v2 of the patch to
incorporate that change.

Thierry
Stephen Warren Oct. 17, 2013, 2:59 p.m.
On 10/17/2013 04:50 AM, Thierry Reding wrote:
> On Thu, Oct 17, 2013 at 11:29:06AM +0200, Alban Bedel wrote:
>> On Mon, 23 Sep 2013 17:23:12 -0700 Tom Warren
>> <TWarren@nvidia.com> wrote:
>> 
>>> It's fine as-is for now. Send a V2 with any changes Stephen, et
>>> al requested (if any), and I'll get it into tegra-next when I
>>> return from vacation next Monday (assuming it's been Acked).
>> 
>> What is the status with this patch serie? I'd really like to get
>> it merged during this window if possible.
> 
> One of the comments was that the SKU is internally listed as
> TM30MQS-A3, not TM30MQS. I assume Tom was expecting you to spin a
> v2 of the patch to incorporate that change.

Are you sure A3 isn't the silicon revision, and hence not part of the
SKU name?
Thierry Reding Oct. 17, 2013, 3:26 p.m.
On Thu, Oct 17, 2013 at 08:59:22AM -0600, Stephen Warren wrote:
> On 10/17/2013 04:50 AM, Thierry Reding wrote:
> > On Thu, Oct 17, 2013 at 11:29:06AM +0200, Alban Bedel wrote:
> >> On Mon, 23 Sep 2013 17:23:12 -0700 Tom Warren
> >> <TWarren@nvidia.com> wrote:
> >> 
> >>> It's fine as-is for now. Send a V2 with any changes Stephen, et
> >>> al requested (if any), and I'll get it into tegra-next when I
> >>> return from vacation next Monday (assuming it's been Acked).
> >> 
> >> What is the status with this patch serie? I'd really like to get
> >> it merged during this window if possible.
> > 
> > One of the comments was that the SKU is internally listed as
> > TM30MQS-A3, not TM30MQS. I assume Tom was expecting you to spin a
> > v2 of the patch to incorporate that change.
> 
> Are you sure A3 isn't the silicon revision, and hence not part of the
> SKU name?

I'm pretty sure. There's a T30MQS-A2 in the same file I found the other
one and that has SKU 0xb3. Well, I suppose that might not mean anything
regarding the silicon, but at least if we stripped -A3 and -A2, then
we'd end up with two different values for the same SKU name.

Thierry
Tom Warren Oct. 17, 2013, 3:45 p.m.
Alban,


On Thu, Oct 17, 2013 at 8:26 AM, Thierry Reding <thierry.reding@gmail.com>wrote:

> On Thu, Oct 17, 2013 at 08:59:22AM -0600, Stephen Warren wrote:
> > On 10/17/2013 04:50 AM, Thierry Reding wrote:
> > > On Thu, Oct 17, 2013 at 11:29:06AM +0200, Alban Bedel wrote:
> > >> On Mon, 23 Sep 2013 17:23:12 -0700 Tom Warren
> > >> <TWarren@nvidia.com> wrote:
> > >>
> > >>> It's fine as-is for now. Send a V2 with any changes Stephen, et
> > >>> al requested (if any), and I'll get it into tegra-next when I
> > >>> return from vacation next Monday (assuming it's been Acked).
> > >>
> > >> What is the status with this patch serie? I'd really like to get
> > >> it merged during this window if possible.
> > >
> > > One of the comments was that the SKU is internally listed as
> > > TM30MQS-A3, not TM30MQS. I assume Tom was expecting you to spin a
> > > v2 of the patch to incorporate that change.
> >
> > Are you sure A3 isn't the silicon revision, and hence not part of the
> > SKU name?
>
> I'm pretty sure. There's a T30MQS-A2 in the same file I found the other
> one and that has SKU 0xb3. Well, I suppose that might not mean anything
> regarding the silicon, but at least if we stripped -A3 and -A2, then
> we'd end up with two different values for the same SKU name.
>
> Thierry
>

Whatever you decide to do here to clear up the SKU naming, I need an
Ack'ed-by patch before I can stick it in u-boot-tegra/next.

Tom

Patch hide | download patch | download mbox

diff --git a/arch/arm/cpu/tegra-common/ap.c b/arch/arm/cpu/tegra-common/ap.c
index 6fb11cb..9e4085c 100644
--- a/arch/arm/cpu/tegra-common/ap.c
+++ b/arch/arm/cpu/tegra-common/ap.c
@@ -71,6 +71,7 @@  int tegra_get_chip_sku(void)
 		switch (sku_id) {
 		case SKU_ID_T33:
 		case SKU_ID_T30:
+		case SKU_ID_T30MQS:
 			return TEGRA_SOC_T30;
 		}
 		break;
diff --git a/arch/arm/include/asm/arch-tegra/tegra.h b/arch/arm/include/asm/arch-tegra/tegra.h
index 25d1fc4..6b6ce85 100644
--- a/arch/arm/include/asm/arch-tegra/tegra.h
+++ b/arch/arm/include/asm/arch-tegra/tegra.h
@@ -65,6 +65,7 @@  enum {
 	SKU_ID_T25E		= 0x1c,
 	SKU_ID_T33		= 0x80,
 	SKU_ID_T30		= 0x81, /* Cardhu value */
+	SKU_ID_T30MQS		= 0xb1,
 	SKU_ID_T114_ENG		= 0x00, /* Dalmore value, unfused */
 	SKU_ID_T114_1		= 0x01,
 };