| Message ID | 1378210424-14781-2-git-send-email-andriy.shevchenko@linux.intel.com |
|---|---|
| State | Superseded, archived |
| Delegated to: | David Miller |
| Headers | show |
On Tue, 2013-09-03 at 15:13 +0300, Andy Shevchenko wrote: [] > diff --git a/drivers/atm/he.c b/drivers/atm/he.c [] > @@ -1088,15 +1088,8 @@ static int he_start(struct atm_dev *dev) > for (i = 0; i < 6; ++i) > dev->esi[i] = read_prom_byte(he_dev, MAC_ADDR + i); > > - hprintk("%s%s, %x:%x:%x:%x:%x:%x\n", > - he_dev->prod_id, > - he_dev->media & 0x40 ? "SM" : "MM", > - dev->esi[0], > - dev->esi[1], > - dev->esi[2], > - dev->esi[3], > - dev->esi[4], > - dev->esi[5]); > + hprintk("%s%s, %*pM\n", he_dev->prod_id, > + he_dev->media & 0x40 ? "SM" : "MM", dev->esi); %*pM? Did this compile cleanly? -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, 2013-09-03 at 05:20 -0700, Joe Perches wrote: > On Tue, 2013-09-03 at 15:13 +0300, Andy Shevchenko wrote: > [] > > diff --git a/drivers/atm/he.c b/drivers/atm/he.c > [] > > @@ -1088,15 +1088,8 @@ static int he_start(struct atm_dev *dev) > > for (i = 0; i < 6; ++i) > > dev->esi[i] = read_prom_byte(he_dev, MAC_ADDR + i); > > > > - hprintk("%s%s, %x:%x:%x:%x:%x:%x\n", > > - he_dev->prod_id, > > - he_dev->media & 0x40 ? "SM" : "MM", > > - dev->esi[0], > > - dev->esi[1], > > - dev->esi[2], > > - dev->esi[3], > > - dev->esi[4], > > - dev->esi[5]); > > + hprintk("%s%s, %*pM\n", he_dev->prod_id, > > + he_dev->media & 0x40 ? "SM" : "MM", dev->esi); > > %*pM? > > Did this compile cleanly? See v2.1 of this patch, and sorry for this typo.
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Date: Tue, 3 Sep 2013 15:13:44 +0300 > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/atm/he.c b/drivers/atm/he.c index 80f9743..c232dd3 100644 --- a/drivers/atm/he.c +++ b/drivers/atm/he.c @@ -1088,15 +1088,8 @@ static int he_start(struct atm_dev *dev) for (i = 0; i < 6; ++i) dev->esi[i] = read_prom_byte(he_dev, MAC_ADDR + i); - hprintk("%s%s, %x:%x:%x:%x:%x:%x\n", - he_dev->prod_id, - he_dev->media & 0x40 ? "SM" : "MM", - dev->esi[0], - dev->esi[1], - dev->esi[2], - dev->esi[3], - dev->esi[4], - dev->esi[5]); + hprintk("%s%s, %*pM\n", he_dev->prod_id, + he_dev->media & 0x40 ? "SM" : "MM", dev->esi); he_dev->atm_dev->link_rate = he_is622(he_dev) ? ATM_OC12_PCR : ATM_OC3_PCR;
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/atm/he.c | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-)