Patchwork [v3] libstdc++/58302

login
register
mail settings
Submitter Paolo Carlini
Date Sept. 3, 2013, 10:22 a.m.
Message ID <5225B84F.90504@oracle.com>
Download mbox | patch
Permalink /patch/272193/
State New
Headers show

Comments

Paolo Carlini - Sept. 3, 2013, 10:22 a.m.
Hi,

a very stupid typo. Tested x86_64-linux, fixed in the active branches.

Thanks,
Paolo.

//////////////////////
2013-09-03  Paolo Carlini  <paolo.carlini@oracle.com>

	PR libstdc++/58302
	* include/bits/random.tcc (negative_binomial_distribution<>::
	operator()(_UniformRandomNumberGenerator&, const param_type&):
	Fix typo in template argument.
	* testsuite/26_numerics/random/negative_binomial_distribution/
	operators/58302.cc: New.

Patch

Index: include/bits/random.tcc
===================================================================
--- include/bits/random.tcc	(revision 202199)
+++ include/bits/random.tcc	(working copy)
@@ -1291,7 +1291,7 @@ 
       operator()(_UniformRandomNumberGenerator& __urng,
 		 const param_type& __p)
       {
-	typedef typename std::gamma_distribution<result_type>::param_type
+	typedef typename std::gamma_distribution<double>::param_type
 	  param_type;
 	
 	const double __y =
Index: testsuite/26_numerics/random/negative_binomial_distribution/operators/58302.cc
===================================================================
--- testsuite/26_numerics/random/negative_binomial_distribution/operators/58302.cc	(revision 0)
+++ testsuite/26_numerics/random/negative_binomial_distribution/operators/58302.cc	(working copy)
@@ -0,0 +1,34 @@ 
+// { dg-do compile }
+// { dg-options "-std=gnu++11" }
+// { dg-require-cstdint "" }
+//
+// Copyright (C) 2013 Free Software Foundation, Inc.
+//
+// This file is part of the GNU ISO C++ Library.  This library is free
+// software; you can redistribute it and/or modify it under the
+// terms of the GNU General Public License as published by the
+// Free Software Foundation; either version 3, or (at your option)
+// any later version.
+//
+// This library is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+// GNU General Public License for more details.
+//
+// You should have received a copy of the GNU General Public License along
+// with this library; see the file COPYING3.  If not see
+// <http://www.gnu.org/licenses/>.
+
+#include <random>
+
+void test01()
+{
+  typedef std::negative_binomial_distribution<> dist_type;
+
+  std::default_random_engine engine;
+
+  dist_type dist;
+  dist_type::param_type param(3, 0.5);
+
+  dist(engine, param); // compile error!
+}