Patchwork powerpc/fsl/defconfig: enable CONFIG_AT803X_PHY

login
register
mail settings
Submitter Shengzhou Liu
Date Sept. 3, 2013, 8:28 a.m.
Message ID <1378196906-9850-1-git-send-email-Shengzhou.Liu@freescale.com>
Download mbox | patch
Permalink /patch/272185/
State Accepted
Commit 788d399d3c3dd1e02ab316272e1dc1881182e16d
Delegated to: Scott Wood
Headers show

Comments

Shengzhou Liu - Sept. 3, 2013, 8:28 a.m.
Enable CONFIG_AT803X_PHY to support AR8030/8033/8035 PHY.

Signed-off-by: Shengzhou Liu <Shengzhou.Liu@freescale.com>
---
 arch/powerpc/configs/corenet32_smp_defconfig |    1 +
 arch/powerpc/configs/mpc85xx_defconfig       |    1 +
 arch/powerpc/configs/mpc85xx_smp_defconfig   |    1 +
 3 files changed, 3 insertions(+), 0 deletions(-)
Scott Wood - Sept. 26, 2013, 1:24 a.m.
On Tue, 2013-09-03 at 16:28 +0800, Shengzhou Liu wrote:
> Enable CONFIG_AT803X_PHY to support AR8030/8033/8035 PHY.
> 
> Signed-off-by: Shengzhou Liu <Shengzhou.Liu@freescale.com>
> ---
>  arch/powerpc/configs/corenet32_smp_defconfig |    1 +
>  arch/powerpc/configs/mpc85xx_defconfig       |    1 +
>  arch/powerpc/configs/mpc85xx_smp_defconfig   |    1 +
>  3 files changed, 3 insertions(+), 0 deletions(-)

Why not corenet64_smp_defconfig?  Which boards have this PHY?

-Scott
Liu Shengzhou-B36685 - Sept. 26, 2013, 3:02 a.m.
> -----Original Message-----
> From: Wood Scott-B07421
> Sent: Thursday, September 26, 2013 9:24 AM
> To: Liu Shengzhou-B36685
> Cc: linuxppc-dev@lists.ozlabs.org; galak@kernel.crashing.org
> Subject: Re: [PATCH] powerpc/fsl/defconfig: enable CONFIG_AT803X_PHY
> 
> On Tue, 2013-09-03 at 16:28 +0800, Shengzhou Liu wrote:
> > Enable CONFIG_AT803X_PHY to support AR8030/8033/8035 PHY.
> >
> > Signed-off-by: Shengzhou Liu <Shengzhou.Liu@freescale.com>
> > ---
> >  arch/powerpc/configs/corenet32_smp_defconfig |    1 +
> >  arch/powerpc/configs/mpc85xx_defconfig       |    1 +
> >  arch/powerpc/configs/mpc85xx_smp_defconfig   |    1 +
> >  3 files changed, 3 insertions(+), 0 deletions(-)
> 
> Why not corenet64_smp_defconfig?  Which boards have this PHY?
> 
> -Scott
> 
Currently AT803X exists on P1010RDB, P1025TWR, etc.
It seems we don't use AT803X for those boards of corenet64.

Regards,
Shengzhou
Scott Wood - Sept. 26, 2013, 9:11 p.m.
On Wed, 2013-09-25 at 22:02 -0500, Liu Shengzhou-B36685 wrote:
> > -----Original Message-----
> > From: Wood Scott-B07421
> > Sent: Thursday, September 26, 2013 9:24 AM
> > To: Liu Shengzhou-B36685
> > Cc: linuxppc-dev@lists.ozlabs.org; galak@kernel.crashing.org
> > Subject: Re: [PATCH] powerpc/fsl/defconfig: enable CONFIG_AT803X_PHY
> > 
> > On Tue, 2013-09-03 at 16:28 +0800, Shengzhou Liu wrote:
> > > Enable CONFIG_AT803X_PHY to support AR8030/8033/8035 PHY.
> > >
> > > Signed-off-by: Shengzhou Liu <Shengzhou.Liu@freescale.com>
> > > ---
> > >  arch/powerpc/configs/corenet32_smp_defconfig |    1 +
> > >  arch/powerpc/configs/mpc85xx_defconfig       |    1 +
> > >  arch/powerpc/configs/mpc85xx_smp_defconfig   |    1 +
> > >  3 files changed, 3 insertions(+), 0 deletions(-)
> > 
> > Why not corenet64_smp_defconfig?  Which boards have this PHY?
> > 
> > -Scott
> > 
> Currently AT803X exists on P1010RDB, P1025TWR, etc.
> It seems we don't use AT803X for those boards of corenet64.

Neither of those boards are corenet32 either.

-Scott
Liu Shengzhou-B36685 - Sept. 27, 2013, 2:51 a.m.
> -----Original Message-----
> From: Wood Scott-B07421
> Sent: Friday, September 27, 2013 5:12 AM
> To: Liu Shengzhou-B36685
> Cc: Wood Scott-B07421; linuxppc-dev@lists.ozlabs.org; galak@kernel.crashing.org
> Subject: Re: [PATCH] powerpc/fsl/defconfig: enable CONFIG_AT803X_PHY
> 
> On Wed, 2013-09-25 at 22:02 -0500, Liu Shengzhou-B36685 wrote:
> > > -----Original Message-----
> > > From: Wood Scott-B07421
> > > Sent: Thursday, September 26, 2013 9:24 AM
> > > To: Liu Shengzhou-B36685
> > > Cc: linuxppc-dev@lists.ozlabs.org; galak@kernel.crashing.org
> > > Subject: Re: [PATCH] powerpc/fsl/defconfig: enable CONFIG_AT803X_PHY
> > >
> > > On Tue, 2013-09-03 at 16:28 +0800, Shengzhou Liu wrote:
> > > > Enable CONFIG_AT803X_PHY to support AR8030/8033/8035 PHY.
> > > >
> > > > Signed-off-by: Shengzhou Liu <Shengzhou.Liu@freescale.com>
> > > > ---
> > > >  arch/powerpc/configs/corenet32_smp_defconfig |    1 +
> > > >  arch/powerpc/configs/mpc85xx_defconfig       |    1 +
> > > >  arch/powerpc/configs/mpc85xx_smp_defconfig   |    1 +
> > > >  3 files changed, 3 insertions(+), 0 deletions(-)
> > >
> > > Why not corenet64_smp_defconfig?  Which boards have this PHY?
> > >
> > > -Scott
> > >
> > Currently AT803X exists on P1010RDB, P1025TWR, etc.
> > It seems we don't use AT803X for those boards of corenet64.
> 
> Neither of those boards are corenet32 either.
> 
Generally, we use AT803X as low-cost solution, it's possible to use it on P1/P2/P3 serial, corenet64 is for high-end case, that's why I didn't enable it for corenet64.
-Shengzhou

Patch

diff --git a/arch/powerpc/configs/corenet32_smp_defconfig b/arch/powerpc/configs/corenet32_smp_defconfig
index 60027c2..ccb9d12 100644
--- a/arch/powerpc/configs/corenet32_smp_defconfig
+++ b/arch/powerpc/configs/corenet32_smp_defconfig
@@ -103,6 +103,7 @@  CONFIG_FSL_PQ_MDIO=y
 CONFIG_E1000=y
 CONFIG_E1000E=y
 CONFIG_VITESSE_PHY=y
+CONFIG_AT803X_PHY=y
 CONFIG_FIXED_PHY=y
 # CONFIG_INPUT_MOUSEDEV is not set
 # CONFIG_INPUT_KEYBOARD is not set
diff --git a/arch/powerpc/configs/mpc85xx_defconfig b/arch/powerpc/configs/mpc85xx_defconfig
index 5a58882..2ddbba5 100644
--- a/arch/powerpc/configs/mpc85xx_defconfig
+++ b/arch/powerpc/configs/mpc85xx_defconfig
@@ -136,6 +136,7 @@  CONFIG_MARVELL_PHY=y
 CONFIG_DAVICOM_PHY=y
 CONFIG_CICADA_PHY=y
 CONFIG_VITESSE_PHY=y
+CONFIG_AT803X_PHY=y
 CONFIG_FIXED_PHY=y
 CONFIG_INPUT_FF_MEMLESS=m
 # CONFIG_INPUT_MOUSEDEV is not set
diff --git a/arch/powerpc/configs/mpc85xx_smp_defconfig b/arch/powerpc/configs/mpc85xx_smp_defconfig
index 152fa05..b08ba94 100644
--- a/arch/powerpc/configs/mpc85xx_smp_defconfig
+++ b/arch/powerpc/configs/mpc85xx_smp_defconfig
@@ -136,6 +136,7 @@  CONFIG_MARVELL_PHY=y
 CONFIG_DAVICOM_PHY=y
 CONFIG_CICADA_PHY=y
 CONFIG_VITESSE_PHY=y
+CONFIG_AT803X_PHY=y
 CONFIG_FIXED_PHY=y
 CONFIG_INPUT_FF_MEMLESS=m
 # CONFIG_INPUT_MOUSEDEV is not set