Patchwork kvm: fix traces to use %x instead of %d

login
register
mail settings
Submitter Alexey Kardashevskiy
Date Sept. 3, 2013, 6:43 a.m.
Message ID <1378190626-21986-1-git-send-email-aik@ozlabs.ru>
Download mbox | patch
Permalink /patch/272124/
State New
Headers show

Comments

Alexey Kardashevskiy - Sept. 3, 2013, 6:43 a.m.
KVM request types are normally defined using hex constants but QEMU traces
print decimal values instead what is not very convinient.

This changes the request type format from %d to %x.

Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
---
 trace-events | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
Paolo Bonzini - Sept. 3, 2013, 7:21 a.m.
Il 03/09/2013 08:43, Alexey Kardashevskiy ha scritto:
> KVM request types are normally defined using hex constants but QEMU traces
> print decimal values instead what is not very convinient.
> 
> This changes the request type format from %d to %x.
> 
> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
> ---
>  trace-events | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/trace-events b/trace-events
> index 4574f29..24cf4d2 100644
> --- a/trace-events
> +++ b/trace-events
> @@ -1171,9 +1171,9 @@ virtio_ccw_new_device(int cssid, int ssid, int schid, int devno, const char *dev
>  migrate_set_state(int new_state) "new state %d"
>  
>  # kvm-all.c
> -kvm_ioctl(int type, void *arg) "type %d, arg %p"
> -kvm_vm_ioctl(int type, void *arg) "type %d, arg %p"
> -kvm_vcpu_ioctl(int cpu_index, int type, void *arg) "cpu_index %d, type %d, arg %p"
> +kvm_ioctl(int type, void *arg) "type %x, arg %p"
> +kvm_vm_ioctl(int type, void *arg) "type %x, arg %p"
> +kvm_vcpu_ioctl(int cpu_index, int type, void *arg) "cpu_index %d, type %x, arg %p"
>  kvm_run_exit(int cpu_index, uint32_t reason) "cpu_index %d, reason %d"
>  
>  # memory.c
> 

Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Andreas Färber - Sept. 3, 2013, 9:47 a.m.
Am 03.09.2013 08:43, schrieb Alexey Kardashevskiy:
> KVM request types are normally defined using hex constants but QEMU traces
> print decimal values instead what is not very convinient.

"which is", "convenient" -- pointing it out early since the KVM guys
don't fix patches once in their queue.

Patch itself:

Reviewed-by: Andreas Färber <afaerber@suse.de>

Andreas

> 
> This changes the request type format from %d to %x.
> 
> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
> ---
>  trace-events | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/trace-events b/trace-events
> index 4574f29..24cf4d2 100644
> --- a/trace-events
> +++ b/trace-events
> @@ -1171,9 +1171,9 @@ virtio_ccw_new_device(int cssid, int ssid, int schid, int devno, const char *dev
>  migrate_set_state(int new_state) "new state %d"
>  
>  # kvm-all.c
> -kvm_ioctl(int type, void *arg) "type %d, arg %p"
> -kvm_vm_ioctl(int type, void *arg) "type %d, arg %p"
> -kvm_vcpu_ioctl(int cpu_index, int type, void *arg) "cpu_index %d, type %d, arg %p"
> +kvm_ioctl(int type, void *arg) "type %x, arg %p"
> +kvm_vm_ioctl(int type, void *arg) "type %x, arg %p"
> +kvm_vcpu_ioctl(int cpu_index, int type, void *arg) "cpu_index %d, type %x, arg %p"
>  kvm_run_exit(int cpu_index, uint32_t reason) "cpu_index %d, reason %d"
>  
>  # memory.c
>
Alexey Kardashevskiy - Sept. 3, 2013, 3:44 p.m.
On 09/03/2013 07:47 PM, Andreas Färber wrote:
> Am 03.09.2013 08:43, schrieb Alexey Kardashevskiy:
>> KVM request types are normally defined using hex constants but QEMU traces
>> print decimal values instead what is not very convinient.
> 
> "which is", "convenient" -- pointing it out early since the KVM guys
> don't fix patches once in their queue.

Sorry, I did not get this. There is a patch like me in a queue?


> Patch itself:
> 
> Reviewed-by: Andreas Färber <afaerber@suse.de>

Thanks!


> Andreas
> 
>>
>> This changes the request type format from %d to %x.
>>
>> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
>> ---
>>  trace-events | 6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/trace-events b/trace-events
>> index 4574f29..24cf4d2 100644
>> --- a/trace-events
>> +++ b/trace-events
>> @@ -1171,9 +1171,9 @@ virtio_ccw_new_device(int cssid, int ssid, int schid, int devno, const char *dev
>>  migrate_set_state(int new_state) "new state %d"
>>  
>>  # kvm-all.c
>> -kvm_ioctl(int type, void *arg) "type %d, arg %p"
>> -kvm_vm_ioctl(int type, void *arg) "type %d, arg %p"
>> -kvm_vcpu_ioctl(int cpu_index, int type, void *arg) "cpu_index %d, type %d, arg %p"
>> +kvm_ioctl(int type, void *arg) "type %x, arg %p"
>> +kvm_vm_ioctl(int type, void *arg) "type %x, arg %p"
>> +kvm_vcpu_ioctl(int cpu_index, int type, void *arg) "cpu_index %d, type %x, arg %p"
>>  kvm_run_exit(int cpu_index, uint32_t reason) "cpu_index %d, reason %d"
>>  
>>  # memory.c
>>
> 
>
Stefan Hajnoczi - Sept. 4, 2013, 10 a.m.
On Tue, Sep 03, 2013 at 04:43:46PM +1000, Alexey Kardashevskiy wrote:
> KVM request types are normally defined using hex constants but QEMU traces
> print decimal values instead what is not very convinient.
> 
> This changes the request type format from %d to %x.
> 
> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
> ---
>  trace-events | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/trace-events b/trace-events
> index 4574f29..24cf4d2 100644
> --- a/trace-events
> +++ b/trace-events
> @@ -1171,9 +1171,9 @@ virtio_ccw_new_device(int cssid, int ssid, int schid, int devno, const char *dev
>  migrate_set_state(int new_state) "new state %d"
>  
>  # kvm-all.c
> -kvm_ioctl(int type, void *arg) "type %d, arg %p"
> -kvm_vm_ioctl(int type, void *arg) "type %d, arg %p"
> -kvm_vcpu_ioctl(int cpu_index, int type, void *arg) "cpu_index %d, type %d, arg %p"
> +kvm_ioctl(int type, void *arg) "type %x, arg %p"
> +kvm_vm_ioctl(int type, void *arg) "type %x, arg %p"
> +kvm_vcpu_ioctl(int cpu_index, int type, void *arg) "cpu_index %d, type %x, arg %p"
>  kvm_run_exit(int cpu_index, uint32_t reason) "cpu_index %d, reason %d"

It would be confusing for someone using these trace events today if you
silently change the base to hex.

To avoid confusion I would use 0x%x or %#x.  This way the output is
self-describing.

Stefan

Patch

diff --git a/trace-events b/trace-events
index 4574f29..24cf4d2 100644
--- a/trace-events
+++ b/trace-events
@@ -1171,9 +1171,9 @@  virtio_ccw_new_device(int cssid, int ssid, int schid, int devno, const char *dev
 migrate_set_state(int new_state) "new state %d"
 
 # kvm-all.c
-kvm_ioctl(int type, void *arg) "type %d, arg %p"
-kvm_vm_ioctl(int type, void *arg) "type %d, arg %p"
-kvm_vcpu_ioctl(int cpu_index, int type, void *arg) "cpu_index %d, type %d, arg %p"
+kvm_ioctl(int type, void *arg) "type %x, arg %p"
+kvm_vm_ioctl(int type, void *arg) "type %x, arg %p"
+kvm_vcpu_ioctl(int cpu_index, int type, void *arg) "cpu_index %d, type %x, arg %p"
 kvm_run_exit(int cpu_index, uint32_t reason) "cpu_index %d, reason %d"
 
 # memory.c