Patchwork physmap.c: Add a dummy release function

login
register
mail settings
Submitter Zev Weiss
Date Sept. 13, 2008, 6:33 a.m.
Message ID <48CB5EA4.10907@gmail.com>
Download mbox | patch
Permalink /patch/272/
State New
Headers show

Comments

Zev Weiss - Sept. 13, 2008, 6:33 a.m.
Adding a dummy release function to the physmap device so as to silence a log
warning on initialization.

Signed-off-by: Zev Weiss <zevweiss@gmail.com>
Lennert Buytenhek - Sept. 13, 2008, 10:47 a.m.
On Fri, Sep 12, 2008 at 11:33:08PM -0700, Zev Weiss wrote:

> Adding a dummy release function to the physmap device so as to silence a log
> warning on initialization.
> 
> Signed-off-by: Zev Weiss <zevweiss@gmail.com>
> ---
>   drivers/mtd/maps/physmap.c |    5 +++++
>   1 files changed, 5 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/mtd/maps/physmap.c b/drivers/mtd/maps/physmap.c
> index 49e2039..73a8d3c 100644
> --- a/drivers/mtd/maps/physmap.c
> +++ b/drivers/mtd/maps/physmap.c
> @@ -277,11 +277,16 @@ static struct resource physmap_flash_resource = {
>   	.flags		= IORESOURCE_MEM,
>   };
> 
> +static void physmap_dummy_release(struct device *dev)
> +{
> +}
> +
>   static struct platform_device physmap_flash = {
>   	.name		= "physmap-flash",
>   	.id		= 0,
>   	.dev		= {
>   		.platform_data	= &physmap_flash_data,
> +		.release	= &physmap_dummy_release,
>   	},
>   	.num_resources	= 1,
>   	.resource	= &physmap_flash_resource,

Isn't that just papering over the issue?
Zev Weiss - Sept. 13, 2008, 11:24 a.m.
Lennert Buytenhek wrote:
> On Fri, Sep 12, 2008 at 11:33:08PM -0700, Zev Weiss wrote:
> 
>> Adding a dummy release function to the physmap device so as to silence a log
>> warning on initialization.
>>
>> Signed-off-by: Zev Weiss <zevweiss@gmail.com>
>> ---
>>   drivers/mtd/maps/physmap.c |    5 +++++
>>   1 files changed, 5 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/mtd/maps/physmap.c b/drivers/mtd/maps/physmap.c
>> index 49e2039..73a8d3c 100644
>> --- a/drivers/mtd/maps/physmap.c
>> +++ b/drivers/mtd/maps/physmap.c
>> @@ -277,11 +277,16 @@ static struct resource physmap_flash_resource = {
>>   	.flags		= IORESOURCE_MEM,
>>   };
>>
>> +static void physmap_dummy_release(struct device *dev)
>> +{
>> +}
>> +
>>   static struct platform_device physmap_flash = {
>>   	.name		= "physmap-flash",
>>   	.id		= 0,
>>   	.dev		= {
>>   		.platform_data	= &physmap_flash_data,
>> +		.release	= &physmap_dummy_release,
>>   	},
>>   	.num_resources	= 1,
>>   	.resource	= &physmap_flash_resource,
> 
> Isn't that just papering over the issue?
> 

Quite possibly -- is there something it *should* be doing?  (I don't mean to suggest 
I particularly think there's not, honest question.)  I had figured it was a minor 
oversight and the warning was sort of a "spurious" one, though I'm admittedly well 
out of my depth here, so perhaps I shouldn't be doing such things (though I suppose 
it's one way to learn).
Andrew Morton - Sept. 17, 2008, 7:01 p.m.
> Subject: [PATCH 3/3] [MTD] physmap.c: Add a dummy release function

Please avoid putting the "MTD" inside the [] characters.  Anything
which is inside [] is supposed to be discarded by the patch-receiving
party.  This is for things like [rfc], [patch 3/12], [2.6.27-rc5], etc.

But we do want the "mtd" text to go all the way through into the
mainline git metadata.

On Fri, 12 Sep 2008 23:33:08 -0700
Zev Weiss <zevweiss@gmail.com> wrote:

> 
> Adding a dummy release function to the physmap device so as to silence a log
> warning on initialization.
> 
> Signed-off-by: Zev Weiss <zevweiss@gmail.com>
> ---
>   drivers/mtd/maps/physmap.c |    5 +++++
>   1 files changed, 5 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/mtd/maps/physmap.c b/drivers/mtd/maps/physmap.c
> index 49e2039..73a8d3c 100644
> --- a/drivers/mtd/maps/physmap.c
> +++ b/drivers/mtd/maps/physmap.c
> @@ -277,11 +277,16 @@ static struct resource physmap_flash_resource = {
>   	.flags		= IORESOURCE_MEM,
>   };
> 
> +static void physmap_dummy_release(struct device *dev)
> +{
> +}
> +
>   static struct platform_device physmap_flash = {
>   	.name		= "physmap-flash",
>   	.id		= 0,
>   	.dev		= {
>   		.platform_data	= &physmap_flash_data,
> +		.release	= &physmap_dummy_release,
>   	},
>   	.num_resources	= 1,
>   	.resource	= &physmap_flash_resource,

Nope.  Please see Documentation/kobject.txt - search for the text
"mocked mercilessly".

Patch

diff --git a/drivers/mtd/maps/physmap.c b/drivers/mtd/maps/physmap.c
index 49e2039..73a8d3c 100644
--- a/drivers/mtd/maps/physmap.c
+++ b/drivers/mtd/maps/physmap.c
@@ -277,11 +277,16 @@  static struct resource physmap_flash_resource = {
  	.flags		= IORESOURCE_MEM,
  };

+static void physmap_dummy_release(struct device *dev)
+{
+}
+
  static struct platform_device physmap_flash = {
  	.name		= "physmap-flash",
  	.id		= 0,
  	.dev		= {
  		.platform_data	= &physmap_flash_data,
+		.release	= &physmap_dummy_release,
  	},
  	.num_resources	= 1,
  	.resource	= &physmap_flash_resource,