Patchwork Powerpc/dts: Correct sdhci quirk for bsc9131

login
register
mail settings
Submitter Haijun.Zhang
Date Sept. 2, 2013, 10:37 a.m.
Message ID <1378118222-17338-1-git-send-email-Haijun.Zhang@freescale.com>
Download mbox | patch
Permalink /patch/271870/
State Accepted
Commit 3169ab00e0727ea2891483e636bd8e6aa11521a1
Delegated to: Scott Wood
Headers show

Comments

Haijun.Zhang - Sept. 2, 2013, 10:37 a.m.
We use property "sdhci,auto-cmd12" instead of "fsl,sdhci-auto-cmd12"
to distinguish if the sdhc host has quirk SDHCI_QUIRK_MULTIBLOCK_READ_ACMD12.

Signed-off-by: Haijun Zhang <Haijun.Zhang@freescale.com>
---
 arch/powerpc/boot/dts/fsl/bsc9131si-post.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Scott Wood - Sept. 16, 2013, 7:42 p.m.
On Mon, 2013-09-16 at 16:12 +0800, Zhang Haijun wrote:
> On 09/02/2013 06:37 PM, Haijun Zhang wrote:
> > We use property "sdhci,auto-cmd12" instead of "fsl,sdhci-auto-cmd12"
> > to distinguish if the sdhc host has quirk SDHCI_QUIRK_MULTIBLOCK_READ_ACMD12.
> >
> > Signed-off-by: Haijun Zhang <Haijun.Zhang@freescale.com>
> > ---
> >   arch/powerpc/boot/dts/fsl/bsc9131si-post.dtsi | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/powerpc/boot/dts/fsl/bsc9131si-post.dtsi b/arch/powerpc/boot/dts/fsl/bsc9131si-post.dtsi
> > index 5180d9d..0c0efa9 100644
> > --- a/arch/powerpc/boot/dts/fsl/bsc9131si-post.dtsi
> > +++ b/arch/powerpc/boot/dts/fsl/bsc9131si-post.dtsi
> > @@ -130,7 +130,7 @@ usb@22000 {
> >
> >   /include/ "pq3-esdhc-0.dtsi"
> >   	sdhc@2e000 {
> > -		fsl,sdhci-auto-cmd12;
> > +		sdhci,auto-cmd12;
> >   		interrupts = <41 0x2 0 0>;
> >   	};
> >
> >
> 
> 
> Hi, scott
> 
> Could you help review this patch?

I process patches in periodic batches.  There's no need for a reminder
when it's only been two weeks, as long as it's still marked "new" or
"under review" in patchwork (and you should include a patchwork link in
any such reminder e-mail).  Especially for a trivial patch such as this,
no comment often means I looked at it and saw no problems and will take
it in the next batch.

Though if you want a comment, don't capitalize "powerpc" in the
subject. :-)

-Scott

Patch

diff --git a/arch/powerpc/boot/dts/fsl/bsc9131si-post.dtsi b/arch/powerpc/boot/dts/fsl/bsc9131si-post.dtsi
index 5180d9d..0c0efa9 100644
--- a/arch/powerpc/boot/dts/fsl/bsc9131si-post.dtsi
+++ b/arch/powerpc/boot/dts/fsl/bsc9131si-post.dtsi
@@ -130,7 +130,7 @@  usb@22000 {
 
 /include/ "pq3-esdhc-0.dtsi"
 	sdhc@2e000 {
-		fsl,sdhci-auto-cmd12;
+		sdhci,auto-cmd12;
 		interrupts = <41 0x2 0 0>;
 	};