| Message ID | 20130902082828.GA30037@elgon.mountain |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
On Mon, 2013-09-02 at 12:04 +0300, Dan Carpenter wrote: > It upsets static analyzers when we don't check for allocation failure. > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Acked-by: Ben Hutchings <bhutchings@solarflare.com> Thanks Dan. Ben. > diff --git a/drivers/net/ethernet/sfc/mtd.c b/drivers/net/ethernet/sfc/mtd.c > index ba6c87a..aac6897 100644 > --- a/drivers/net/ethernet/sfc/mtd.c > +++ b/drivers/net/ethernet/sfc/mtd.c > @@ -384,6 +384,8 @@ static int falcon_mtd_probe(struct efx_nic *efx) > > /* Allocate space for maximum number of partitions */ > parts = kcalloc(2, sizeof(*parts), GFP_KERNEL); > + if (!parts) > + return -ENOMEM; > n_parts = 0; > > spi = &nic_data->spi_flash;
From: Dan Carpenter <dan.carpenter@oracle.com> Date: Mon, 2 Sep 2013 12:04:42 +0300 > It upsets static analyzers when we don't check for allocation failure. > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> This applies cleanly neither to net nor net-next, please send me a version that does. Thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, 2013-09-03 at 22:49 -0400, David Miller wrote: > From: Dan Carpenter <dan.carpenter@oracle.com> > Date: Mon, 2 Sep 2013 12:04:42 +0300 > > > It upsets static analyzers when we don't check for allocation failure. > > > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > > This applies cleanly neither to net nor net-next, please send me a > version that does. Oh yes, I failed to spot the filename. That function has since been moved to falcon.c. Ben.
diff --git a/drivers/net/ethernet/sfc/mtd.c b/drivers/net/ethernet/sfc/mtd.c index ba6c87a..aac6897 100644 --- a/drivers/net/ethernet/sfc/mtd.c +++ b/drivers/net/ethernet/sfc/mtd.c @@ -384,6 +384,8 @@ static int falcon_mtd_probe(struct efx_nic *efx) /* Allocate space for maximum number of partitions */ parts = kcalloc(2, sizeof(*parts), GFP_KERNEL); + if (!parts) + return -ENOMEM; n_parts = 0; spi = &nic_data->spi_flash;
It upsets static analyzers when we don't check for allocation failure. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html