Patchwork net: netx-eth: remove unnecessary casting when using dev_get_platdata()

login
register
mail settings
Submitter Jingoo Han
Date Sept. 2, 2013, 12:37 a.m.
Message ID <004b01cea774$975b48b0$c611da10$%han@samsung.com>
Download mbox | patch
Permalink /patch/271662/
State Changes Requested
Delegated to: David Miller
Headers show

Comments

Jingoo Han - Sept. 2, 2013, 12:37 a.m.
Casting from 'void *' is unnecessary when using dev_get_platdata().

Reported-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
 drivers/net/ethernet/netx-eth.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Sergei Shtylyov - Sept. 2, 2013, 9:01 p.m.
Hello.

On 09/02/2013 04:37 AM, Jingoo Han wrote:

> Casting from 'void *' is unnecessary when using dev_get_platdata().

    dev_get_platdata() is irrelevant here. Casting from/to 'void *' to/from 
any pointer type is just automatic.

> Reported-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/net/ethernet/netx-eth.c b/drivers/net/ethernet/netx-eth.c
index 235fd51..e6f0a43 100644
--- a/drivers/net/ethernet/netx-eth.c
+++ b/drivers/net/ethernet/netx-eth.c
@@ -390,7 +390,7 @@  static int netx_eth_drv_probe(struct platform_device *pdev)
 
 	priv = netdev_priv(ndev);
 
-	pdata = (struct netxeth_platform_data *)dev_get_platdata(&pdev->dev);
+	pdata = dev_get_platdata(&pdev->dev);
 	priv->xc = request_xc(pdata->xcno, &pdev->dev);
 	if (!priv->xc) {
 		dev_err(&pdev->dev, "unable to request xc engine\n");