Patchwork [3/3] powerpc/spufs: remove double check for non-negative dentry

login
register
mail settings
Submitter Arnd Bergmann
Date May 13, 2009, 3:58 p.m.
Message ID <200905131758.57327.arnd@arndb.de>
Download mbox | patch
Permalink /patch/27156/
State Accepted
Commit 45db9240890d9343c934db1fe82d6e68ac2d28da
Delegated to: Benjamin Herrenschmidt
Headers show

Comments

Arnd Bergmann - May 13, 2009, 3:58 p.m.
From: Jan Blunck <jblunck@suse.de>

This patch removes an unnecessary double check if the dentry returned by
lookup_create() is actually non-negative. Since lookup_create() itself returns
an error in this case just remove the check.

Signed-off-by: Jan Blunck <jblunck@suse.de>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 arch/powerpc/platforms/cell/spufs/inode.c |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)

Patch

diff --git a/arch/powerpc/platforms/cell/spufs/inode.c b/arch/powerpc/platforms/cell/spufs/inode.c
index 706eb5c..36b6700 100644
--- a/arch/powerpc/platforms/cell/spufs/inode.c
+++ b/arch/powerpc/platforms/cell/spufs/inode.c
@@ -631,10 +631,6 @@  long spufs_create(struct nameidata *nd, unsigned int flags, mode_t mode,
 	if (IS_ERR(dentry))
 		goto out_dir;
 
-	ret = -EEXIST;
-	if (dentry->d_inode)
-		goto out_dput;
-
 	mode &= ~current_umask();
 
 	if (flags & SPU_CREATE_GANG)