From patchwork Fri Aug 30 21:49:27 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rob Herring X-Patchwork-Id: 271451 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 8E85E2C00C4 for ; Sat, 31 Aug 2013 07:50:23 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756867Ab3H3VuN (ORCPT ); Fri, 30 Aug 2013 17:50:13 -0400 Received: from mail-ob0-f179.google.com ([209.85.214.179]:46938 "EHLO mail-ob0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756107Ab3H3VuH (ORCPT ); Fri, 30 Aug 2013 17:50:07 -0400 Received: by mail-ob0-f179.google.com with SMTP id fb19so2389938obc.38 for ; Fri, 30 Aug 2013 14:50:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=dgStfrFAX+VmMwBVdfksRS2IEJPyZE1IOy3FsQZzj4o=; b=baguxAlPPE7bM4XO7t8eINagquaKElEwVe6E6jjTsWBKUxJ3ndJIpOF37wT11yPUhd 0XcLiHwQK87AsS1ok3mhPlmmzldTlgOcsasrG4JjyVlTrgSijJbhBzIuxdAuyMtFJSbe T/hUqaEXWbTZXE+SvUo6i8NiojCWuHpXh35JMfwevYWIYr0U3t3UIiLvGFC2PyLRMcOa CQalAaHKqHMPADhdjO2j0JrxF3FiB9Y3fzWaPsQNa7p4tfskL8sSEW0ZpoNVZ5tOeWtX 6NtAjVvSlpgUBu//Dg9q6DNDUHG0CN5Rg7L5sJAMm3IstG8AvrkduYGLGpeW4YossceK +zvA== X-Received: by 10.182.230.163 with SMTP id sz3mr8253323obc.81.1377899407495; Fri, 30 Aug 2013 14:50:07 -0700 (PDT) Received: from rob-laptop.calxeda.com ([173.226.190.126]) by mx.google.com with ESMTPSA id qi5sm47974obb.6.1969.12.31.16.00.00 (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 30 Aug 2013 14:50:06 -0700 (PDT) From: Rob Herring To: netdev@vger.kernel.org Cc: Ben Hutchings , Lennert Buytenhek , Rob Herring Subject: [PATCH v3 09/11] net: calxedaxgmac: remove some unused statistic counters Date: Fri, 30 Aug 2013 16:49:27 -0500 Message-Id: <1377899369-23252-9-git-send-email-robherring2@gmail.com> X-Mailer: git-send-email 1.8.1.2 In-Reply-To: <1377899369-23252-1-git-send-email-robherring2@gmail.com> References: <1377899369-23252-1-git-send-email-robherring2@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Rob Herring rx_sa_filter_fail and tx_undeflow events are unused and impossible to occur based on how the h/w is used. We never filter on source MAC address and TX store and forward mode prevents underflow events. Reported-by: Lennert Buytenhek Signed-off-by: Rob Herring --- drivers/net/ethernet/calxeda/xgmac.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/ethernet/calxeda/xgmac.c b/drivers/net/ethernet/calxeda/xgmac.c index 0cff9e3..04c585c 100644 --- a/drivers/net/ethernet/calxeda/xgmac.c +++ b/drivers/net/ethernet/calxeda/xgmac.c @@ -353,11 +353,9 @@ struct xgmac_extra_stats { /* Receive errors */ unsigned long rx_watchdog; unsigned long rx_da_filter_fail; - unsigned long rx_sa_filter_fail; unsigned long rx_payload_error; unsigned long rx_ip_header_error; /* Tx/Rx IRQ errors */ - unsigned long tx_undeflow; unsigned long tx_process_stopped; unsigned long rx_buf_unav; unsigned long rx_process_stopped; @@ -1581,7 +1579,6 @@ static const struct xgmac_stats xgmac_gstrings_stats[] = { XGMAC_STAT(rx_payload_error), XGMAC_STAT(rx_ip_header_error), XGMAC_STAT(rx_da_filter_fail), - XGMAC_STAT(rx_sa_filter_fail), XGMAC_STAT(fatal_bus_error), XGMAC_HW_STAT(rx_watchdog, XGMAC_MMC_RXWATCHDOG), XGMAC_HW_STAT(tx_vlan, XGMAC_MMC_TXVLANFRAME),