Patchwork [v3,01/11] net: calxedaxgmac: remove NETIF_F_FRAGLIST setting

login
register
mail settings
Submitter Rob Herring
Date Aug. 30, 2013, 9:49 p.m.
Message ID <1377899369-23252-1-git-send-email-robherring2@gmail.com>
Download mbox | patch
Permalink /patch/271446/
State Accepted
Delegated to: David Miller
Headers show

Comments

Rob Herring - Aug. 30, 2013, 9:49 p.m.
From: Rob Herring <rob.herring@calxeda.com>

The xgmac does not actually handle frag lists, so this option should not
be set. It does not appear to have had any impact though.

Reported-by: Lennert Buytenhek <buytenh@wantstofly.org>
Signed-off-by: Rob Herring <rob.herring@calxeda.com>
---
 drivers/net/ethernet/calxeda/xgmac.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
David Miller - Sept. 4, 2013, 2:22 a.m.
Series applied, thanks.

In the future, when you send more than one patch at a time, always provide
an initial "[PATCH 00/NN] " posting which gives a top-level overview
description of your patch series and what it achieves.

You can look at what other developers do on this list for examples.

Thank you.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/net/ethernet/calxeda/xgmac.c b/drivers/net/ethernet/calxeda/xgmac.c
index 7cb148c..71f6720 100644
--- a/drivers/net/ethernet/calxeda/xgmac.c
+++ b/drivers/net/ethernet/calxeda/xgmac.c
@@ -1759,7 +1759,7 @@  static int xgmac_probe(struct platform_device *pdev)
 	if (device_can_wakeup(priv->device))
 		priv->wolopts = WAKE_MAGIC;	/* Magic Frame as default */
 
-	ndev->hw_features = NETIF_F_SG | NETIF_F_FRAGLIST | NETIF_F_HIGHDMA;
+	ndev->hw_features = NETIF_F_SG | NETIF_F_HIGHDMA;
 	if (readl(priv->base + XGMAC_DMA_HW_FEATURE) & DMA_HW_FEAT_TXCOESEL)
 		ndev->hw_features |= NETIF_F_IP_CSUM | NETIF_F_IPV6_CSUM |
 				     NETIF_F_RXCSUM;