Patchwork [c++,testsuite] : Improve g++.dg/abi/mangle33.C scan-asm pattern

login
register
mail settings
Submitter Mike Stump
Date Aug. 30, 2013, 3:50 p.m.
Message ID <FB96CA7F-F714-49E8-9338-E514A4837E0B@comcast.net>
Download mbox | patch
Permalink /patch/271344/
State New
Headers show

Comments

Mike Stump - Aug. 30, 2013, 3:50 p.m.
On Aug 30, 2013, at 2:02 AM, Uros Bizjak <ubizjak@gmail.com> wrote:
> I was looking at annoying
> 
> ERROR: g++.dg/abi/mangle33.C -std=c++98: error executing dg-final:
> couldn't compile regular expression pattern: out of memory

Wow…  They are amazingly clueless.  What part of the mandate, though shall not claim out of memory until the last byte of my 4 TB drive is allocated did you not understand?  Could someone file a tcl bug and say they want a 100 MB regexp please, the 1980s are over.  I was going to say 10 MB, and realized that is what I would have said in 1994, then realized it isn't 1994 anymore either.

 [ pause ]

I filed:

  http://core.tcl.tk/tcl/tktview/267b7e2334ee2e9de34c4b00d6e72e2f1997085f

Thanks for finding the original tcl bug and tracking this down and letting us know it was a regression from 8.5 to 8.6.

> The patch was tested with Tcl 8.5 where it works without problems.
> 
> OK for mainline?

Ok.

> BTW: There are a couple of similar problems with Tcl 8.6:

> [1] http://sourceforge.net/p/tcl/bugs/5178/

:-(  closed.

I've amended the Tcl pointer with the bug pointer:

2013-08-30  Mike Stump  <mikestump@comcast.net>

        * doc/install.texi (Prerequisites): Note regression in Tcl 8.6 with RE patterns.



I usually don't like enshrining bug reports into the documentation, but, for this bug, I'll make an exception.  Now, I'm hoping they will actually fix this in tcl, so that we don't have to do anything special in the test suite.  Wake me in a year and let's see if they fixed it.

Patch

Index: doc/install.texi
===================================================================
--- doc/install.texi	(revision 202083)
+++ doc/install.texi	(working copy)
@@ -426,7 +426,11 @@  Necessary when modifying @command{gperf}
 @itemx Expect
 @itemx Tcl
 
-Necessary to run the GCC testsuite; see the section on testing for details.
+Necessary to run the GCC testsuite; see the section on testing for
+details.  Tcl 8.6 has a known regression in RE pattern handling that
+make parts of the testsuite fail.  See
+@uref{http://core.tcl.tk/tcl/tktview/267b7e2334ee2e9de34c4b00d6e72e2f1997085f}
+for more information.
 
 @item autogen version 5.5.4 (or later) and
 @itemx guile version 1.4.1 (or later)