Patchwork ipv6: ipv6_create_tempaddr cleanup

login
register
mail settings
Submitter Petr Holasek
Date Aug. 30, 2013, 3:02 p.m.
Message ID <1377874958-2426-1-git-send-email-pholasek@redhat.com>
Download mbox | patch
Permalink /patch/271324/
State Accepted
Delegated to: David Miller
Headers show

Comments

Petr Holasek - Aug. 30, 2013, 3:02 p.m.
This two-liner removes max_addresses variable which is now unecessary related
to patch [ipv6: remove max_addresses check from ipv6_create_tempaddr].

Signed-off-by: Petr Holasek <pholasek@redhat.com>
---
 net/ipv6/addrconf.c | 2 --
 1 file changed, 2 deletions(-)
Hannes Frederic Sowa - Sept. 1, 2013, 6:35 p.m.
On Fri, Aug 30, 2013 at 05:02:38PM +0200, Petr Holasek wrote:
> This two-liner removes max_addresses variable which is now unecessary related
> to patch [ipv6: remove max_addresses check from ipv6_create_tempaddr].
> 
> Signed-off-by: Petr Holasek <pholasek@redhat.com>

Uh, yes, I missed that. Thanks a lot!

Acked-by: Hannes Frederic Sowa <hannes@stressinduktion.org>

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Ding Tianhong - Sept. 2, 2013, 2:32 p.m.
于 2013/9/2 2:35, Hannes Frederic Sowa 写道:
> On Fri, Aug 30, 2013 at 05:02:38PM +0200, Petr Holasek wrote:
>> This two-liner removes max_addresses variable which is now unecessary related
>> to patch [ipv6: remove max_addresses check from ipv6_create_tempaddr].
>>
>> Signed-off-by: Petr Holasek <pholasek@redhat.com>
> Uh, yes, I missed that. Thanks a lot!
>
> Acked-by: Hannes Frederic Sowa <hannes@stressinduktion.org>

Acked-by: Ding Tianhong <dingtianhong@huawei.com>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller - Sept. 4, 2013, 2:17 a.m.
From: Petr Holasek <pholasek@redhat.com>
Date: Fri, 30 Aug 2013 17:02:38 +0200

> This two-liner removes max_addresses variable which is now unecessary related
> to patch [ipv6: remove max_addresses check from ipv6_create_tempaddr].
> 
> Signed-off-by: Petr Holasek <pholasek@redhat.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
index 498ea99..05c83dd 100644
--- a/net/ipv6/addrconf.c
+++ b/net/ipv6/addrconf.c
@@ -1054,7 +1054,6 @@  static int ipv6_create_tempaddr(struct inet6_ifaddr *ifp, struct inet6_ifaddr *i
 	unsigned long regen_advance;
 	int tmp_plen;
 	int ret = 0;
-	int max_addresses;
 	u32 addr_flags;
 	unsigned long now = jiffies;
 
@@ -1100,7 +1099,6 @@  retry:
 				 idev->cnf.temp_prefered_lft + age -
 				 idev->cnf.max_desync_factor);
 	tmp_plen = ifp->prefix_len;
-	max_addresses = idev->cnf.max_addresses;
 	tmp_tstamp = ifp->tstamp;
 	spin_unlock_bh(&ifp->lock);