Patchwork P2P: Immediate group removal in GC in case of deauthentication

login
register
mail settings
Submitter Sreenath
Date Aug. 30, 2013, 1:08 p.m.
Message ID <20130830130825.GA9742@sreenath-Precision-M4700>
Download mbox | patch
Permalink /patch/271287/
State Accepted
Commit 43ee470494a78440db8eb675ed67dc0e9f9e4cf9
Headers show

Comments

Sreenath - Aug. 30, 2013, 1:08 p.m.
Right now in case of deauthentication from GO, immediate group removal will
happen in GC only if the deauthentication packet has a valid IE. However
the IE in deauthentication packet is mandated only for managed P2P group.
So in normal P2P group the group removal is delayed and will happen later
only in group idle timeout.

Signed-hostap: Sreenath Sharma <sreenats@broadcom.com>
---
 wpa_supplicant/events.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Jouni Malinen - Aug. 31, 2013, 8:14 a.m.
On Fri, Aug 30, 2013 at 06:38:25PM +0530, Sreenath Sharma wrote:
> Right now in case of deauthentication from GO, immediate group removal will
> happen in GC only if the deauthentication packet has a valid IE. However
> the IE in deauthentication packet is mandated only for managed P2P group.
> So in normal P2P group the group removal is delayed and will happen later
> only in group idle timeout.

Thanks! Applied with a note added to the commit message to identify the
commit d7df0fa727a2a79d7b22df6c68961220349ab2e3 that caused this
regression.

Patch

diff --git a/wpa_supplicant/events.c b/wpa_supplicant/events.c
index 40c6adf..8d6c234 100644
--- a/wpa_supplicant/events.c
+++ b/wpa_supplicant/events.c
@@ -2473,7 +2473,7 @@  static void wpas_event_disconnect(struct wpa_supplicant *wpa_s, const u8 *addr,
 		wpas_auth_failed(wpa_s);
 
 #ifdef CONFIG_P2P
-	if (deauth && ie && ie_len > 0) {
+	if (deauth && reason_code > 0) {
 		if (wpas_p2p_deauth_notif(wpa_s, addr, reason_code, ie, ie_len,
 					  locally_generated) > 0) {
 			/*