| Message ID | 003f01cea53d$b88030c0$29809240$%han@samsung.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
Hello. On 08/30/2013 08:59 AM, Jingoo Han wrote: > Use the wrapper function for retrieving the platform data instead of > accessing dev->platform_data directly. This is a cosmetic change > to make the code simpler and enhance the readability. > Signed-off-by: Jingoo Han <jg1.han@samsung.com> > --- > drivers/net/ethernet/netx-eth.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > diff --git a/drivers/net/ethernet/netx-eth.c b/drivers/net/ethernet/netx-eth.c > index dc2c6f5..235fd51 100644 > --- a/drivers/net/ethernet/netx-eth.c > +++ b/drivers/net/ethernet/netx-eth.c > @@ -390,7 +390,7 @@ static int netx_eth_drv_probe(struct platform_device *pdev) > > priv = netdev_priv(ndev); > > - pdata = (struct netxeth_platform_data *)pdev->dev.platform_data; > + pdata = (struct netxeth_platform_data *)dev_get_platdata(&pdev->dev); Cast from 'void *' is not needed. This is a material of another patch, of course... WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/ethernet/netx-eth.c b/drivers/net/ethernet/netx-eth.c index dc2c6f5..235fd51 100644 --- a/drivers/net/ethernet/netx-eth.c +++ b/drivers/net/ethernet/netx-eth.c @@ -390,7 +390,7 @@ static int netx_eth_drv_probe(struct platform_device *pdev) priv = netdev_priv(ndev); - pdata = (struct netxeth_platform_data *)pdev->dev.platform_data; + pdata = (struct netxeth_platform_data *)dev_get_platdata(&pdev->dev); priv->xc = request_xc(pdata->xcno, &pdev->dev); if (!priv->xc) { dev_err(&pdev->dev, "unable to request xc engine\n");
Use the wrapper function for retrieving the platform data instead of accessing dev->platform_data directly. This is a cosmetic change to make the code simpler and enhance the readability. Signed-off-by: Jingoo Han <jg1.han@samsung.com> --- drivers/net/ethernet/netx-eth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)