From patchwork Sat Sep 13 06:32:58 2008 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zev Weiss X-Patchwork-Id: 271 Return-Path: X-Original-To: patchwork@ozlabs.org Delivered-To: patchwork@ozlabs.org Received: from bombadil.infradead.org (bombadil.infradead.org [18.85.46.34]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 376FADDDFD for ; Sat, 13 Sep 2008 16:33:40 +1000 (EST) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.68 #1 (Red Hat Linux)) id 1KeOgz-0002Ps-9i; Sat, 13 Sep 2008 06:33:13 +0000 Received: from wf-out-1314.google.com ([209.85.200.174]) by bombadil.infradead.org with esmtp (Exim 4.68 #1 (Red Hat Linux)) id 1KeOgo-0000nZ-I1 for linux-mtd@lists.infradead.org; Sat, 13 Sep 2008 06:33:06 +0000 Received: by wf-out-1314.google.com with SMTP id 28so1126154wfc.24 for ; Fri, 12 Sep 2008 23:33:01 -0700 (PDT) Received: by 10.142.14.18 with SMTP id 18mr1779882wfn.129.1221287581724; Fri, 12 Sep 2008 23:33:01 -0700 (PDT) Received: from ?192.168.1.2? ( [24.84.185.161]) by mx.google.com with ESMTPS id 30sm17091168wfg.9.2008.09.12.23.33.00 (version=TLSv1/SSLv3 cipher=RC4-MD5); Fri, 12 Sep 2008 23:33:00 -0700 (PDT) Message-ID: <48CB5E9A.4010000@gmail.com> Date: Fri, 12 Sep 2008 23:32:58 -0700 From: Zev Weiss User-Agent: Thunderbird 2.0.0.16 (X11/20080723) MIME-Version: 1.0 To: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/3] [MTD] physmap.c: Check return of platform_device_register() X-Spam-Score: 0.0 (/) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.9 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-mtd-bounces@lists.infradead.org Errors-To: linux-mtd-bounces+patchwork=ozlabs.org@lists.infradead.org The PHYSMAP_COMPAT code had been ignoring the return value of platform_device_register() in the physmap_init() function. Signed-off-by: Zev Weiss diff --git a/drivers/mtd/maps/physmap.c b/drivers/mtd/maps/physmap.c index 42d844f..6fba0d4 100644 --- a/drivers/mtd/maps/physmap.c +++ b/drivers/mtd/maps/physmap.c @@ -312,7 +312,7 @@ static int __init physmap_init(void) err = platform_driver_register(&physmap_flash_driver); #ifdef PHYSMAP_COMPAT if (err == 0) - platform_device_register(&physmap_flash); + err = platform_device_register(&physmap_flash); #endif return err;