Patchwork [GIT,PULL] arm: dts: SOCFPGA updates for v3.12

login
register
mail settings
Submitter dinguyen@altera.com
Date Aug. 28, 2013, 10:38 p.m.
Message ID <1377729528-24305-1-git-send-email-dinguyen@altera.com>
Download mbox
Permalink /patch/270651/
State New
Headers show

Pull-request

git://git.rocketboards.org/linux-socfpga-next.git next-dt

Comments

dinguyen@altera.com - Aug. 28, 2013, 10:38 p.m.
From: Dinh Nguyen <dinguyen@altera.com>

Hi Olof/Kevin,

This is my first pull request to you guys, so I apologize in advance if
something is not correct.

Here is a short description of the ACKs for the 3 patches:
of: add vendor prefix for Altera Corp.
	Acked-by: Mark Rutland <mark.rutland@arm.com>
	Acked-by: Stephen Warren <swarren@wwwdotorg.org>
dts: Deprecate ALTR as a vendor prefix
	Acked-by: Stephen Warren <swarren@wwwdotorg.org>
arm: dts: Change dw-apb-timer-osc and dw-apb-timer-sp to just dw-apb-timer
	Acked-by: Stephen Warren <swarren@wwwdotorg.org>

Thanks,
Dinh
--------------------------------------------------------------

The following changes since commit fa8218def1b1a16f0a410e2c1c767b4738cc81fa:

  Merge tag 'regmap-v3.11-rc7' of git://git.kernel.org/pub/scm/linux/kernel/git/broonie/regmap (2013-08-27 10:10:30 -0700)

are available in the git repository at:


  git://git.rocketboards.org/linux-socfpga-next.git next-dt

for you to fetch changes up to 4d4dd417b8c0ba99c68038ccf2d0256dcd460ead:

  arm: dts: Change dw-apb-timer-osc and dw-apb-timer-sp to  just dw-apb-timer (2013-08-28 17:11:25 -0500)

---------------------------------------------------------------
SOCFPGA DT changes for v3.12 merge window.

----------------------------------------------------------------
Dinh Nguyen (3):
      of: add vendor prefix for Altera Corp.
      dts: Deprecate ALTR as a vendor prefix
      arm: dts: Change dw-apb-timer-osc and dw-apb-timer-sp to      just dw-apb-timer

 Documentation/devicetree/bindings/rtc/dw-apb.txt   |   34 +++++++-------------
 .../devicetree/bindings/serial/altera_jtaguart.txt |    3 +-
 .../devicetree/bindings/serial/altera_uart.txt     |    3 +-
 .../devicetree/bindings/serio/altera_ps2.txt       |    3 +-
 .../devicetree/bindings/spi/spi_altera.txt         |    3 +-
 .../devicetree/bindings/vendor-prefixes.txt        |    1 +
 arch/arm/boot/dts/socfpga.dtsi                     |    8 ++---
 drivers/input/serio/altera_ps2.c                   |    1 +
 drivers/spi/spi-altera.c                           |    1 +
 drivers/tty/serial/altera_jtaguart.c               |    1 +
 drivers/tty/serial/altera_uart.c                   |    1 +
 11 files changed, 28 insertions(+), 31 deletions(-)
Olof Johansson - Aug. 29, 2013, 7:56 p.m.
Hi,


On Wed, Aug 28, 2013 at 05:38:48PM -0500, dinguyen@altera.com wrote:
> From: Dinh Nguyen <dinguyen@altera.com>
> 
> Hi Olof/Kevin,
> 
> This is my first pull request to you guys, so I apologize in advance if
> something is not correct.

A couple of comments:

> The following changes since commit fa8218def1b1a16f0a410e2c1c767b4738cc81fa:
> 
>   Merge tag 'regmap-v3.11-rc7' of git://git.kernel.org/pub/scm/linux/kernel/git/broonie/regmap (2013-08-27 10:10:30 -0700)

We ask that you base your branches on a full -rc release from Linus, and it
doesn't have to be the very latest one at that -- we almost prefer one that's
already in our tree.

> are available in the git repository at:
> 
> 
>   git://git.rocketboards.org/linux-socfpga-next.git next-dt

Please push the tag to the server so it's part of the pull request. And please
write up a few sentences about what is in the branch/tag in the tag itself. See
how some of the other maintainers do it for an idea of what to have there: I'm
mostly looking for higher-level description of what is there.

> ----------------------------------------------------------------
> Dinh Nguyen (3):
>       of: add vendor prefix for Altera Corp.
>       dts: Deprecate ALTR as a vendor prefix
>       arm: dts: Change dw-apb-timer-osc and dw-apb-timer-sp to      just dw-apb-timer

The subject on this is too long and wrapped weirdly. I'd just name it
"dts: rename DW apb timers".

>  Documentation/devicetree/bindings/rtc/dw-apb.txt   |   34 +++++++-------------
>  .../devicetree/bindings/serial/altera_jtaguart.txt |    3 +-
>  .../devicetree/bindings/serial/altera_uart.txt     |    3 +-
>  .../devicetree/bindings/serio/altera_ps2.txt       |    3 +-
>  .../devicetree/bindings/spi/spi_altera.txt         |    3 +-
>  .../devicetree/bindings/vendor-prefixes.txt        |    1 +
>  arch/arm/boot/dts/socfpga.dtsi                     |    8 ++---
>  drivers/input/serio/altera_ps2.c                   |    1 +
>  drivers/spi/spi-altera.c                           |    1 +
>  drivers/tty/serial/altera_jtaguart.c               |    1 +
>  drivers/tty/serial/altera_uart.c                   |    1 +

These changes are all DT-related, so in the future as you have more patches
this would go in a "dt" topic/category branch, and other updates might go in
other branches. That's something you'll learn as you go (and we'll help you :).


I'll take this branch and rebase/reapply the patches this time, but keep the
above in mind for next release. :)

-Olof
Barry Song - Aug. 29, 2013, 11:45 p.m.
> We ask that you base your branches on a full -rc release from Linus, and it
> doesn't have to be the very latest one at that -- we almost prefer one that's
> already in our tree.
>
> > are available in the git repository at:
> >
> >
> >   git://git.rocketboards.org/linux-socfpga-next.git next-dt
>
> Please push the tag to the server so it's part of the pull request. And please
> write up a few sentences about what is in the branch/tag in the tag itself. See
> how some of the other maintainers do it for an idea of what to have there: I'm
> mostly looking for higher-level description of what is there.

hi Dinh,
you might refer to
http://lwn.net/Articles/461236/
https://www.kernel.org/pub/software/scm/git/docs/howto/using-signed-tag-in-pull-request.html
-barry