From patchwork Wed Aug 28 17:06:04 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Uros Bizjak X-Patchwork-Id: 270606 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "www.sourceware.org", Issuer "StartCom Class 1 Primary Intermediate Server CA" (not verified)) by ozlabs.org (Postfix) with ESMTPS id B566B2C00BF for ; Thu, 29 Aug 2013 03:06:14 +1000 (EST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :mime-version:date:message-id:subject:from:to:cc:content-type; q=dns; s=default; b=PTklmCRzGYQlTrL44BivTaGTTJBQnzIrRFqdRQRkqb/ UsfhBFJMD9Gk5GipRYobQTxXaOQEe5ihlQDgJHGOeKCWFxsN4ABAHFhqlPvQjkMw 5ig2RRfFHXSk2F3WEQdhaM/F9Ge249lqCkWnWDv+CxbdcpmdeIBf+OUJ5zkaCFY8 = DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :mime-version:date:message-id:subject:from:to:cc:content-type; s=default; bh=YN6curH2hmbMWqlSleNdizzyIFg=; b=VT6Ryxljf2jbXA0JP uJhNRWwNafwNY+uSRDl2KQTtVTYqdq+Pj5Pck+i4+HAqMXWadcG36h7QWQd/UFSO F05er5FwZNXTVpbToEzWhq9Wtl5k+5lqlXUwoYq9x7Eo/bHeHeeTtjVEI2WegrXS UhIzn/YaHVDNDNcjzmvyahNLmA= Received: (qmail 30705 invoked by alias); 28 Aug 2013 17:06:07 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 30696 invoked by uid 89); 28 Aug 2013 17:06:07 -0000 Received: from mail-ob0-f178.google.com (HELO mail-ob0-f178.google.com) (209.85.214.178) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Wed, 28 Aug 2013 17:06:07 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL, BAYES_00, FREEMAIL_FROM, NO_RELAYS autolearn=ham version=3.3.2 X-HELO: mail-ob0-f178.google.com Received: by mail-ob0-f178.google.com with SMTP id ef5so7115946obb.9 for ; Wed, 28 Aug 2013 10:06:04 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.60.16.104 with SMTP id f8mr1243674oed.71.1377709564706; Wed, 28 Aug 2013 10:06:04 -0700 (PDT) Received: by 10.182.137.136 with HTTP; Wed, 28 Aug 2013 10:06:04 -0700 (PDT) Date: Wed, 28 Aug 2013 19:06:04 +0200 Message-ID: Subject: [PATCH, tm]: Annotate _ITM_free as leaf From: Uros Bizjak To: "gcc-patches@gcc.gnu.org" Cc: Jakub Jelinek , Jan Hubicka Hello! >> while adding LEAF attributes, I apparently missed free. Malloc is already annotated. >> Fixed thus. Comitted as obvoius. > > Given that glibc headers mark free as leaf and nothing has been reported > against it, it is probably fine; but you've ignored the comment that > told you to adjust also BUILT_IN_TM_FREE. Like in attached patch. 2013-08-28 Uros Bizjak * gtm-builtins.def (_ITM_free): Declare leaf. Tested on x86_64-pc-linux-gnu {,-m32}. OK for mainline? Uros. Index: gcc/gtm-builtins.def =================================================================== --- gcc/gtm-builtins.def (revision 202054) +++ gcc/gtm-builtins.def (working copy) @@ -28,7 +28,7 @@ DEF_TM_BUILTIN (BUILT_IN_TM_MALLOC, "_ITM_malloc", DEF_TM_BUILTIN (BUILT_IN_TM_CALLOC, "_ITM_calloc", BT_FN_PTR_SIZE_SIZE, ATTR_TMPURE_MALLOC_NOTHROW_LIST) DEF_TM_BUILTIN (BUILT_IN_TM_FREE, "_ITM_free", - BT_FN_VOID_PTR, ATTR_TMPURE_NOTHROW_LIST) + BT_FN_VOID_PTR, ATTR_TMPURE_NOTHROW_LEAF_LIST) /* Logging builtins. */ DEF_TM_BUILTIN (BUILT_IN_TM_LOG_1, "_ITM_LU1",