From patchwork Wed Aug 28 13:24:26 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paolo Carlini X-Patchwork-Id: 270510 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "www.sourceware.org", Issuer "StartCom Class 1 Primary Intermediate Server CA" (not verified)) by ozlabs.org (Postfix) with ESMTPS id 697472C0095 for ; Wed, 28 Aug 2013 23:24:41 +1000 (EST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:date:from:mime-version:to:cc:subject:content-type; q=dns; s=default; b=uoHiUYiFLVr64wu/Mjph8cUpHZIfVWsrSsd+eM6aOa2 d6QLkubbDAysmgGTTsSOgrRldgMXseiuBlZ3gILlMXkGePERE984DXQmJ8WMXCVn 0YRje0n75Ckhs1Kt5ViKwkYfnre0rNg637DKjwr55TJ+/fZCp4ZoPJWgvIy2dOlk = DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:date:from:mime-version:to:cc:subject:content-type; s=default; bh=HltqYDLhiojjYJmdzc2HeenpcHk=; b=WP3JWdko2eOBatAAk eyX0fpzCmSNvnH4Wh3zxvSb7OWnWYRNmG2RMiQHmBkqy4ghWg/tP+PGhax5UEuVB qVBzOFaXDHYkzgFUhPEtIwRxBuX+iJy7BMydBIZENNvE1Ico9iVoQrlUoHNHol78 O9iv9BAmPUxgVwL41GHdhVvuxQ= Received: (qmail 11350 invoked by alias); 28 Aug 2013 13:24:34 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 11341 invoked by uid 89); 28 Aug 2013 13:24:34 -0000 Received: from userp1040.oracle.com (HELO userp1040.oracle.com) (156.151.31.81) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Wed, 28 Aug 2013 13:24:34 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-6.5 required=5.0 tests=AWL, BAYES_00, KHOP_RCVD_UNTRUST, RCVD_IN_HOSTKARMA_W, RCVD_IN_HOSTKARMA_WL, RP_MATCHES_RCVD, SPF_SOFTFAIL, UNPARSEABLE_RELAY autolearn=ham version=3.3.2 X-HELO: userp1040.oracle.com Received: from acsinet22.oracle.com (acsinet22.oracle.com [141.146.126.238]) by userp1040.oracle.com (Sentrion-MTA-4.3.1/Sentrion-MTA-4.3.1) with ESMTP id r7SDOUaq016206 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 28 Aug 2013 13:24:31 GMT Received: from userz7021.oracle.com (userz7021.oracle.com [156.151.31.85]) by acsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r7SDOTp3003041 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 28 Aug 2013 13:24:29 GMT Received: from abhmt120.oracle.com (abhmt120.oracle.com [141.146.116.72]) by userz7021.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r7SDOSfG001875; Wed, 28 Aug 2013 13:24:28 GMT Received: from poldo4.casa (/79.43.213.94) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 28 Aug 2013 06:24:28 -0700 Message-ID: <521DFA0A.4010105@oracle.com> Date: Wed, 28 Aug 2013 15:24:26 +0200 From: Paolo Carlini User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130801 Thunderbird/17.0.8 MIME-Version: 1.0 To: "gcc-patches@gcc.gnu.org" CC: Jason Merrill Subject: [C++ Patch] PR 58255 Hi, for value-initialization (thus void_type_node as init), explicit should not matter, thus we shouldn't set LOOKUP_ONLYCONVERTING. I also double checked that we do the right thing for testcases like: struct A { explicit A(int = 0); }; A a1 = 1; /* error */ A a2; /* Ok */ A a3(2); /* Ok */ As expected, in such cases init is an INTEGER_CST, a NULL_TREE and a TREE_LIST of a single INTEGER_CST, respectively. Booted and tested x86_64-linux. Thanks, Paolo. ///////////////////////////// /cp 2013-08-28 Paolo Carlini PR c++/58255 * init.c (build_aggr_init): When init == void_type_node do not set LOOKUP_ONLYCONVERTING. /testsuite 2013-08-28 Paolo Carlini PR c++/58255 * g++.dg/cpp0x/dc7.C: New. Index: cp/init.c =================================================================== --- cp/init.c (revision 202020) +++ cp/init.c (working copy) @@ -1464,7 +1464,8 @@ build_aggr_init (tree exp, tree init, int flags, t TREE_READONLY (exp) = 0; TREE_THIS_VOLATILE (exp) = 0; - if (init && TREE_CODE (init) != TREE_LIST + if (init && init != void_type_node + && TREE_CODE (init) != TREE_LIST && !(TREE_CODE (init) == TARGET_EXPR && TARGET_EXPR_DIRECT_INIT_P (init)) && !(BRACE_ENCLOSED_INITIALIZER_P (init) Index: testsuite/g++.dg/cpp0x/dc7.C =================================================================== --- testsuite/g++.dg/cpp0x/dc7.C (revision 0) +++ testsuite/g++.dg/cpp0x/dc7.C (working copy) @@ -0,0 +1,7 @@ +// PR c++/58255 +// { dg-do compile { target c++11 } } + +struct A { + explicit A() { } + A(int x) : A() { } +};