Patchwork [U-Boot,1/4] drivers/rtc/davinci.c: Reference DAVINCI_RTC_BASE more directly

login
register
mail settings
Submitter Tom Rini
Date Aug. 28, 2013, 1 p.m.
Message ID <1377694830-16906-1-git-send-email-trini@ti.com>
Download mbox | patch
Permalink /patch/270503/
State Accepted
Delegated to: Tom Rini
Headers show

Comments

Tom Rini - Aug. 28, 2013, 1 p.m.
We shouldn't rely on a define to hide this cast for us.

Signed-off-by: Tom Rini <trini@ti.com>
---
 drivers/rtc/davinci.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
Tom Rini - Nov. 4, 2013, 2:17 p.m.
On Wed, Aug 28, 2013 at 09:00:27AM -0400, Tom Rini wrote:

> We shouldn't rely on a define to hide this cast for us.
> 
> Signed-off-by: Tom Rini <trini@ti.com>

Applied to u-boot-ti/master.

Patch

diff --git a/drivers/rtc/davinci.c b/drivers/rtc/davinci.c
index e60c0da..018779e 100644
--- a/drivers/rtc/davinci.c
+++ b/drivers/rtc/davinci.c
@@ -13,7 +13,7 @@ 
 #if defined(CONFIG_CMD_DATE)
 int rtc_get(struct rtc_time *tmp)
 {
-	struct davinci_rtc *rtc = davinci_rtc_base;
+	struct davinci_rtc *rtc = (struct davinci_rtc *)DAVINCI_RTC_BASE;
 	unsigned long sec, min, hour, mday, wday, mon_cent, year;
 	unsigned long status;
 
@@ -57,7 +57,7 @@  int rtc_get(struct rtc_time *tmp)
 
 int rtc_set(struct rtc_time *tmp)
 {
-	struct davinci_rtc *rtc = davinci_rtc_base;
+	struct davinci_rtc *rtc = (struct davinci_rtc *)DAVINCI_RTC_BASE;
 
 	debug("Set DATE: %4d-%02d-%02d (wday=%d)  TIME: %2d:%02d:%02d\n",
 		tmp->tm_year, tmp->tm_mon, tmp->tm_mday, tmp->tm_wday,
@@ -75,7 +75,7 @@  int rtc_set(struct rtc_time *tmp)
 
 void rtc_reset(void)
 {
-	struct davinci_rtc *rtc = davinci_rtc_base;
+	struct davinci_rtc *rtc = (struct davinci_rtc *)DAVINCI_RTC_BASE;
 
 	/* run RTC counter */
 	writel(0x01, &rtc->ctrl);