Patchwork [v2,1/2] qemu-timer: drop outdated signal safety comments

login
register
mail settings
Submitter Stefan Hajnoczi
Date Aug. 27, 2013, 8:23 a.m.
Message ID <1377591839-2743-2-git-send-email-stefanha@redhat.com>
Download mbox | patch
Permalink /patch/270062/
State New
Headers show

Comments

Stefan Hajnoczi - Aug. 27, 2013, 8:23 a.m.
host_alarm_handler() is invoked from the signal processing thread
(currently the iothread).  Previously we did processing in a real signal
handler with signalfd and therefore needed signal-safe timer code.

Today host_alarm_handler() just marks the alarm timer as expired/pending
and notifies the main loop using qemu_notify_event().

Therefore these outdated comments about signal safety can be dropped.

Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
 qemu-timer.c | 4 ----
 1 file changed, 4 deletions(-)
Alex Bligh - Aug. 27, 2013, 8:43 a.m.
On 27 Aug 2013, at 09:23, Stefan Hajnoczi wrote:

> host_alarm_handler() is invoked from the signal processing thread
> (currently the iothread).  Previously we did processing in a real signal
> handler with signalfd and therefore needed signal-safe timer code.
> 
> Today host_alarm_handler() just marks the alarm timer as expired/pending
> and notifies the main loop using qemu_notify_event().
> 
> Therefore these outdated comments about signal safety can be dropped.
> 
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>

Signed-off-by: Alex Bligh <alex@alex.org.uk>

Ooops - meant to delete these myself.

> ---
> qemu-timer.c | 4 ----
> 1 file changed, 4 deletions(-)
> 
> diff --git a/qemu-timer.c b/qemu-timer.c
> index 95ff47f..ed3fcb2 100644
> --- a/qemu-timer.c
> +++ b/qemu-timer.c
> @@ -301,8 +301,6 @@ void timer_del(QEMUTimer *ts)
> {
>     QEMUTimer **pt, *t;
> 
> -    /* NOTE: this code must be signal safe because
> -       timer_expired() can be called from a signal. */
>     pt = &ts->timer_list->active_timers;
>     for(;;) {
>         t = *pt;
> @@ -325,8 +323,6 @@ void timer_mod_ns(QEMUTimer *ts, int64_t expire_time)
>     timer_del(ts);
> 
>     /* add the timer in the sorted list */
> -    /* NOTE: this code must be signal safe because
> -       timer_expired() can be called from a signal. */
>     pt = &ts->timer_list->active_timers;
>     for(;;) {
>         t = *pt;
> -- 
> 1.8.3.1
> 
> 
>

Patch

diff --git a/qemu-timer.c b/qemu-timer.c
index 95ff47f..ed3fcb2 100644
--- a/qemu-timer.c
+++ b/qemu-timer.c
@@ -301,8 +301,6 @@  void timer_del(QEMUTimer *ts)
 {
     QEMUTimer **pt, *t;
 
-    /* NOTE: this code must be signal safe because
-       timer_expired() can be called from a signal. */
     pt = &ts->timer_list->active_timers;
     for(;;) {
         t = *pt;
@@ -325,8 +323,6 @@  void timer_mod_ns(QEMUTimer *ts, int64_t expire_time)
     timer_del(ts);
 
     /* add the timer in the sorted list */
-    /* NOTE: this code must be signal safe because
-       timer_expired() can be called from a signal. */
     pt = &ts->timer_list->active_timers;
     for(;;) {
         t = *pt;