| Message ID | 1377582316-11050-1-git-send-email-sourav.poddar@ti.com |
|---|---|
| State | Superseded |
| Delegated to: | Jagannadha Sutradharudu Teki |
| Headers | show |
Hi On Tue, Aug 27, 2013 at 11:15 AM, Sourav Poddar <sourav.poddar@ti.com> wrote: > Add support for macronix "MX66L51235L" flash device. > > Signed-off-by: Sourav Poddar <sourav.poddar@ti.com> > --- > drivers/mtd/spi/macronix.c | 5 +++++ > 1 files changed, 5 insertions(+), 0 deletions(-) > > diff --git a/drivers/mtd/spi/macronix.c b/drivers/mtd/spi/macronix.c > index 70435eb..5a528c3 100644 > --- a/drivers/mtd/spi/macronix.c > +++ b/drivers/mtd/spi/macronix.c > @@ -61,6 +61,11 @@ static const struct macronix_spi_flash_params macronix_spi_flash_table[] = { > .nr_blocks = 256, > .name = "MX25L12855E", > }, > + { > + .idcode = 0x201a, > + .nr_blocks = 512, > + .name = "MX66L51235L", > + }, > }; > Can you check the similar patch http://patchwork.ozlabs.org/patch/262928/ Please confirm about nr_blocks? Also have u tested with latest spi_flash code, since ur part is 64MB must require a BAR to access entire memory.? http://patchwork.ozlabs.org/patch/262929/ Let me know for any concerns. -- Thanks, Jagan.
Hi Sourav, Can you test this macronix part w.r.t latest code base on u-boot-spi.git with master-probe branch. Please let me know about any issues/concerns. On Tue, Aug 27, 2013 at 2:48 PM, Jagan Teki <jagannadh.teki@gmail.com> wrote: > Hi > > On Tue, Aug 27, 2013 at 11:15 AM, Sourav Poddar <sourav.poddar@ti.com> wrote: >> Add support for macronix "MX66L51235L" flash device. >> >> Signed-off-by: Sourav Poddar <sourav.poddar@ti.com> >> --- >> drivers/mtd/spi/macronix.c | 5 +++++ >> 1 files changed, 5 insertions(+), 0 deletions(-) >> >> diff --git a/drivers/mtd/spi/macronix.c b/drivers/mtd/spi/macronix.c >> index 70435eb..5a528c3 100644 >> --- a/drivers/mtd/spi/macronix.c >> +++ b/drivers/mtd/spi/macronix.c >> @@ -61,6 +61,11 @@ static const struct macronix_spi_flash_params macronix_spi_flash_table[] = { >> .nr_blocks = 256, >> .name = "MX25L12855E", >> }, >> + { >> + .idcode = 0x201a, >> + .nr_blocks = 512, >> + .name = "MX66L51235L", >> + }, >> }; >> > > Can you check the similar patch > http://patchwork.ozlabs.org/patch/262928/ > > Please confirm about nr_blocks? > Also have u tested with latest spi_flash code, since ur part is 64MB > must require a BAR to access entire memory.? > http://patchwork.ozlabs.org/patch/262929/ > > Let me know for any concerns. > > -- > Thanks, > Jagan.
On Thursday 03 October 2013 09:19 PM, Jagan Teki wrote: > Hi Sourav, > > Can you test this macronix part w.r.t latest code base on > u-boot-spi.git with master-probe branch. > Please let me know about any issues/concerns. > Regarding the number of blocks, it should be 1024 only. I will do other testing asap and let you know. This particular flash is on another SOC so I will send that SOC specific qspi data after testing it with the subject patch. > On Tue, Aug 27, 2013 at 2:48 PM, Jagan Teki<jagannadh.teki@gmail.com> wrote: >> Hi >> >> On Tue, Aug 27, 2013 at 11:15 AM, Sourav Poddar<sourav.poddar@ti.com> wrote: >>> Add support for macronix "MX66L51235L" flash device. >>> >>> Signed-off-by: Sourav Poddar<sourav.poddar@ti.com> >>> --- >>> drivers/mtd/spi/macronix.c | 5 +++++ >>> 1 files changed, 5 insertions(+), 0 deletions(-) >>> >>> diff --git a/drivers/mtd/spi/macronix.c b/drivers/mtd/spi/macronix.c >>> index 70435eb..5a528c3 100644 >>> --- a/drivers/mtd/spi/macronix.c >>> +++ b/drivers/mtd/spi/macronix.c >>> @@ -61,6 +61,11 @@ static const struct macronix_spi_flash_params macronix_spi_flash_table[] = { >>> .nr_blocks = 256, >>> .name = "MX25L12855E", >>> }, >>> + { >>> + .idcode = 0x201a, >>> + .nr_blocks = 512, >>> + .name = "MX66L51235L", >>> + }, >>> }; >>> >> Can you check the similar patch >> http://patchwork.ozlabs.org/patch/262928/ >> >> Please confirm about nr_blocks? >> Also have u tested with latest spi_flash code, since ur part is 64MB >> must require a BAR to access entire memory.? >> http://patchwork.ozlabs.org/patch/262929/ >> >> Let me know for any concerns. >> >> -- >> Thanks, >> Jagan. > >
On Mon, Oct 7, 2013 at 8:50 PM, Sourav Poddar <sourav.poddar@ti.com> wrote: > On Thursday 03 October 2013 09:19 PM, Jagan Teki wrote: >> >> Hi Sourav, >> >> Can you test this macronix part w.r.t latest code base on >> u-boot-spi.git with master-probe branch. >> Please let me know about any issues/concerns. >> > Regarding the number of blocks, it should be 1024 only. > > I will do other testing asap and let you know. This particular flash > is on another SOC so I will send that SOC specific qspi data after testing > it > with the subject patch. OK, thanks. Please use u-boot-spi.git master branch. > >> On Tue, Aug 27, 2013 at 2:48 PM, Jagan Teki<jagannadh.teki@gmail.com> >> wrote: >>> >>> Hi >>> >>> On Tue, Aug 27, 2013 at 11:15 AM, Sourav Poddar<sourav.poddar@ti.com> >>> wrote: >>>> >>>> Add support for macronix "MX66L51235L" flash device. >>>> >>>> Signed-off-by: Sourav Poddar<sourav.poddar@ti.com> >>>> --- >>>> drivers/mtd/spi/macronix.c | 5 +++++ >>>> 1 files changed, 5 insertions(+), 0 deletions(-) >>>> >>>> diff --git a/drivers/mtd/spi/macronix.c b/drivers/mtd/spi/macronix.c >>>> index 70435eb..5a528c3 100644 >>>> --- a/drivers/mtd/spi/macronix.c >>>> +++ b/drivers/mtd/spi/macronix.c >>>> @@ -61,6 +61,11 @@ static const struct macronix_spi_flash_params >>>> macronix_spi_flash_table[] = { >>>> .nr_blocks = 256, >>>> .name = "MX25L12855E", >>>> }, >>>> + { >>>> + .idcode = 0x201a, >>>> + .nr_blocks = 512, >>>> + .name = "MX66L51235L", >>>> + }, >>>> }; >>>> >>> Can you check the similar patch >>> http://patchwork.ozlabs.org/patch/262928/ >>> >>> Please confirm about nr_blocks? >>> Also have u tested with latest spi_flash code, since ur part is 64MB >>> must require a BAR to access entire memory.? >>> http://patchwork.ozlabs.org/patch/262929/ >>> >>> Let me know for any concerns. >>> >>> -- >>> Thanks, >>> Jagan. >> >> >> >
diff --git a/drivers/mtd/spi/macronix.c b/drivers/mtd/spi/macronix.c index 70435eb..5a528c3 100644 --- a/drivers/mtd/spi/macronix.c +++ b/drivers/mtd/spi/macronix.c @@ -61,6 +61,11 @@ static const struct macronix_spi_flash_params macronix_spi_flash_table[] = { .nr_blocks = 256, .name = "MX25L12855E", }, + { + .idcode = 0x201a, + .nr_blocks = 512, + .name = "MX66L51235L", + }, }; struct spi_flash *spi_flash_probe_macronix(struct spi_slave *spi, u8 *idcode)
Add support for macronix "MX66L51235L" flash device. Signed-off-by: Sourav Poddar <sourav.poddar@ti.com> --- drivers/mtd/spi/macronix.c | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-)