From patchwork Mon Aug 26 21:00:08 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 269984 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 9379B2C0087 for ; Tue, 27 Aug 2013 07:25:01 +1000 (EST) Received: from localhost ([::1]:53034 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VE3wL-0005z8-Sp for incoming@patchwork.ozlabs.org; Mon, 26 Aug 2013 17:03:09 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47225) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VE3uF-0002oO-PD for qemu-devel@nongnu.org; Mon, 26 Aug 2013 17:01:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VE3u9-00058K-31 for qemu-devel@nongnu.org; Mon, 26 Aug 2013 17:00:59 -0400 Received: from mail-qe0-x234.google.com ([2607:f8b0:400d:c02::234]:45648) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VE3u8-00058E-Ve for qemu-devel@nongnu.org; Mon, 26 Aug 2013 17:00:53 -0400 Received: by mail-qe0-f52.google.com with SMTP id a11so2090564qen.39 for ; Mon, 26 Aug 2013 14:00:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=59mZoPNXoguILjoEEdc7c7K3ILYf1zfgqiRx8dslt2A=; b=OuXBJFUFruc+IVo2iK+AhmdX6w48YLmQivm5seYKmDa1KmDizH0yULHwHlAxRO4RZQ PlkjoA05JfTwdqSQA2Vu7b74GdZm81vvW4H8sC70KIs1BwEnzTXiQXqGCOZuq8T81WVa qANB9cXi2WFNw35XqOvxKYvde2k9ZWLn2HTDbYLg9/A+R3Ss7pAdobYcSqfz+Zxy7/Or /iRvwn58nv7xErU/XK6t5xtaCCjIM/iHe2HO98xf3SMKV22zjl77Lluf0P6c0rh4JOIq 8eHCU7V/zXxYEqWKGwf/qAJrIobGFKD3FSm0FLqj3VHil4NJFEhyHJIJS5NWJtI8Fj8K WOWw== X-Received: by 10.49.101.98 with SMTP id ff2mr19903716qeb.11.1377550852554; Mon, 26 Aug 2013 14:00:52 -0700 (PDT) Received: from anchor.com (50-194-63-110-static.hfc.comcastbusiness.net. [50.194.63.110]) by mx.google.com with ESMTPSA id q4sm24499705qah.2.1969.12.31.16.00.00 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Mon, 26 Aug 2013 14:00:51 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Mon, 26 Aug 2013 14:00:08 -0700 Message-Id: <1377550812-908-4-git-send-email-rth@twiddle.net> X-Mailer: git-send-email 1.8.1.4 In-Reply-To: <1377550812-908-1-git-send-email-rth@twiddle.net> References: <1377550812-908-1-git-send-email-rth@twiddle.net> X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:400d:c02::234 Cc: anthony@codemonkey.ws, aurelien@aurel32.net Subject: [Qemu-devel] [PULL 3/7] tcg-i386: Try pc-relative lea for constant formation X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Use a 7 byte lea before the ultimate 10 byte movq. Signed-off-by: Richard Henderson --- tcg/i386/tcg-target.c | 25 ++++++++++++++++++++----- 1 file changed, 20 insertions(+), 5 deletions(-) diff --git a/tcg/i386/tcg-target.c b/tcg/i386/tcg-target.c index 841bd75..8226171 100644 --- a/tcg/i386/tcg-target.c +++ b/tcg/i386/tcg-target.c @@ -541,19 +541,34 @@ static inline void tcg_out_mov(TCGContext *s, TCGType type, static void tcg_out_movi(TCGContext *s, TCGType type, TCGReg ret, tcg_target_long arg) { + tcg_target_long diff; + if (arg == 0) { tgen_arithr(s, ARITH_XOR, ret, ret); return; - } else if (arg == (uint32_t)arg || type == TCG_TYPE_I32) { + } + if (arg == (uint32_t)arg || type == TCG_TYPE_I32) { tcg_out_opc(s, OPC_MOVL_Iv + LOWREGMASK(ret), 0, ret, 0); tcg_out32(s, arg); - } else if (arg == (int32_t)arg) { + return; + } + if (arg == (int32_t)arg) { tcg_out_modrm(s, OPC_MOVL_EvIz + P_REXW, 0, ret); tcg_out32(s, arg); - } else { - tcg_out_opc(s, OPC_MOVL_Iv + P_REXW + LOWREGMASK(ret), 0, ret, 0); - tcg_out64(s, arg); + return; } + + /* Try a 7 byte pc-relative lea before the 10 byte movq. */ + diff = arg - ((tcg_target_long)s->code_ptr + 7); + if (diff == (int32_t)diff) { + tcg_out_opc(s, OPC_LEA | P_REXW, ret, 0, 0); + tcg_out8(s, (LOWREGMASK(ret) << 3) | 5); + tcg_out32(s, diff); + return; + } + + tcg_out_opc(s, OPC_MOVL_Iv + P_REXW + LOWREGMASK(ret), 0, ret, 0); + tcg_out64(s, arg); } static inline void tcg_out_pushi(TCGContext *s, tcg_target_long val)