From patchwork Mon Aug 26 21:00:07 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 269980 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id F346A2C007A for ; Tue, 27 Aug 2013 07:01:34 +1000 (EST) Received: from localhost ([::1]:53017 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VE3um-0002w0-Uf for incoming@patchwork.ozlabs.org; Mon, 26 Aug 2013 17:01:32 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47218) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VE3uE-0002oI-Rc for qemu-devel@nongnu.org; Mon, 26 Aug 2013 17:01:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VE3u7-000586-8Q for qemu-devel@nongnu.org; Mon, 26 Aug 2013 17:00:58 -0400 Received: from mail-qa0-x22b.google.com ([2607:f8b0:400d:c00::22b]:57467) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VE3u7-000582-4Y for qemu-devel@nongnu.org; Mon, 26 Aug 2013 17:00:51 -0400 Received: by mail-qa0-f43.google.com with SMTP id bq6so1150134qab.16 for ; Mon, 26 Aug 2013 14:00:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=ytpuC3QQCefqI73GcWFGsOFO+RhkdGbswnFhsGJj8Es=; b=LgE7AJGdBEmSVSK2+0RM409rZCR4xsT6J56cHN9TihOzIzzlLwRk083J8hJLSAn6Fz epGZz6QSKeUQBY56+2qdhsBIIroh84q75nlK8QPdPgcASL/2pACVK07EVhxzS/6waEvE iAX1NJHMtGcNRItuCWPxZeId6UyIk9/Hjhxn4WcSFm7QKBN9APCSRSQJXYHO8/ddq9o3 GgyUIIh/t8uyVtN0xjJzZmvy9exCY/dghIyTNtWAVl+hS1kfi0WoXK2g/qt0T6p2iNk4 4NirWUpH0H0eK+xFUr8C1jKtt6y2ZWpPN1hKN+lYJomMmY/PuCLY/j8Va3XEAQb0Hbf6 PtKw== X-Received: by 10.49.50.232 with SMTP id f8mr18443180qeo.63.1377550850690; Mon, 26 Aug 2013 14:00:50 -0700 (PDT) Received: from anchor.com (50-194-63-110-static.hfc.comcastbusiness.net. [50.194.63.110]) by mx.google.com with ESMTPSA id q4sm24499705qah.2.1969.12.31.16.00.00 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Mon, 26 Aug 2013 14:00:50 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Mon, 26 Aug 2013 14:00:07 -0700 Message-Id: <1377550812-908-3-git-send-email-rth@twiddle.net> X-Mailer: git-send-email 1.8.1.4 In-Reply-To: <1377550812-908-1-git-send-email-rth@twiddle.net> References: <1377550812-908-1-git-send-email-rth@twiddle.net> X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:400d:c00::22b Cc: anthony@codemonkey.ws, aurelien@aurel32.net Subject: [Qemu-devel] [PULL 2/7] tcg-i386: Add and use tcg_out64 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org No point in splitting the write into 32-bit pieces. Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- tcg/i386/tcg-target.c | 3 +-- tcg/tcg.c | 7 +++++++ 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/tcg/i386/tcg-target.c b/tcg/i386/tcg-target.c index 87eeab3..841bd75 100644 --- a/tcg/i386/tcg-target.c +++ b/tcg/i386/tcg-target.c @@ -552,8 +552,7 @@ static void tcg_out_movi(TCGContext *s, TCGType type, tcg_out32(s, arg); } else { tcg_out_opc(s, OPC_MOVL_Iv + P_REXW + LOWREGMASK(ret), 0, ret, 0); - tcg_out32(s, arg); - tcg_out32(s, arg >> 31 >> 1); + tcg_out64(s, arg); } } diff --git a/tcg/tcg.c b/tcg/tcg.c index 42c95af..19bd5a3 100644 --- a/tcg/tcg.c +++ b/tcg/tcg.c @@ -133,6 +133,13 @@ static inline void tcg_out32(TCGContext *s, uint32_t v) s->code_ptr = p + 4; } +static inline void tcg_out64(TCGContext *s, uint64_t v) +{ + uint8_t *p = s->code_ptr; + *(uint64_t *)p = v; + s->code_ptr = p + 8; +} + /* label relocation processing */ static void tcg_out_reloc(TCGContext *s, uint8_t *code_ptr, int type,