Patchwork mmc: Add fsl,esdhc as a valid compatible to bind against

login
register
mail settings
Submitter Kumar Gala
Date May 8, 2009, 1:52 p.m.
Message ID <1241790769-3843-1-git-send-email-galak@kernel.crashing.org>
Download mbox | patch
Permalink /patch/26994/
State Accepted, archived
Delegated to: Kumar Gala
Headers show

Comments

Kumar Gala - May 8, 2009, 1:52 p.m.
We plan to use fsl,esdhc going forward as the base compatible so update
the driver to bind against it.

Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
---
 drivers/mmc/host/sdhci-of.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
Michael Ellerman - May 11, 2009, 2:38 a.m.
On Fri, 2009-05-08 at 08:52 -0500, Kumar Gala wrote:
> We plan to use fsl,esdhc going forward as the base compatible so update
> the driver to bind against it.

I was going to NAK this based on its non-sensical changelog, but going
backward you're not the first to be going forward :)

cheers
Kumar Gala - May 14, 2009, 2:45 a.m.
On May 8, 2009, at 8:52 AM, Kumar Gala wrote:

> We plan to use fsl,esdhc going forward as the base compatible so  
> update
> the driver to bind against it.
>
> Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
> ---
> drivers/mmc/host/sdhci-of.c |    1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)

Any feedback or possibility of picking this up.

- k

>
>
> diff --git a/drivers/mmc/host/sdhci-of.c b/drivers/mmc/host/sdhci-of.c
> index 3ff4ac3..09cc597 100644
> --- a/drivers/mmc/host/sdhci-of.c
> +++ b/drivers/mmc/host/sdhci-of.c
> @@ -277,6 +277,7 @@ static int __devexit sdhci_of_remove(struct  
> of_device *ofdev)
> static const struct of_device_id sdhci_of_match[] = {
> 	{ .compatible = "fsl,mpc8379-esdhc", .data = &sdhci_esdhc, },
> 	{ .compatible = "fsl,mpc8536-esdhc", .data = &sdhci_esdhc, },
> +	{ .compatible = "fsl,esdhc", .data = &sdhci_esdhc, },
> 	{ .compatible = "generic-sdhci", },
> 	{},
> };
> -- 
> 1.6.0.6
>
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev
Pierre Ossman - May 22, 2009, 11:53 a.m.
On Fri,  8 May 2009 08:52:49 -0500
Kumar Gala <galak@kernel.crashing.org> wrote:

> We plan to use fsl,esdhc going forward as the base compatible so update
> the driver to bind against it.
> 
> Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
> ---

Applied.

Rgds

Patch

diff --git a/drivers/mmc/host/sdhci-of.c b/drivers/mmc/host/sdhci-of.c
index 3ff4ac3..09cc597 100644
--- a/drivers/mmc/host/sdhci-of.c
+++ b/drivers/mmc/host/sdhci-of.c
@@ -277,6 +277,7 @@  static int __devexit sdhci_of_remove(struct of_device *ofdev)
 static const struct of_device_id sdhci_of_match[] = {
 	{ .compatible = "fsl,mpc8379-esdhc", .data = &sdhci_esdhc, },
 	{ .compatible = "fsl,mpc8536-esdhc", .data = &sdhci_esdhc, },
+	{ .compatible = "fsl,esdhc", .data = &sdhci_esdhc, },
 	{ .compatible = "generic-sdhci", },
 	{},
 };