diff mbox

[1/1] DMA: mark DMA_nBITS_MASK as deprecated

Message ID 1241769638-27301-1-git-send-email-jirislaby@gmail.com
State Not Applicable, archived
Delegated to: David Miller
Headers show

Commit Message

Jiri Slaby May 8, 2009, 8 a.m. UTC 
Ingo Molnar <mingo@elte.hu> wrote:
> Can you see a way to emit build warnings? If yes then that might be 
> a better solution instead of breaking in-the-pipeline code.

What about this:
--

Mark them deprecated so that 3rd party vendors get notified about that
before their modules break by removing those macros later.

Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
---
 include/linux/dma-mapping.h |   26 ++++++++++++++------------
 1 files changed, 14 insertions(+), 12 deletions(-)

Comments

FUJITA Tomonori May 9, 2009, 11:55 p.m. UTC | #1 
On Fri,  8 May 2009 10:00:38 +0200
Jiri Slaby <jirislaby@gmail.com> wrote:

> Ingo Molnar <mingo@elte.hu> wrote:
> > Can you see a way to emit build warnings? If yes then that might be 
> > a better solution instead of breaking in-the-pipeline code.
> 
> What about this:
> --
> 
> Mark them deprecated so that 3rd party vendors get notified about that
> before their modules break by removing those macros later.
> 
> Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
> ---
>  include/linux/dma-mapping.h |   26 ++++++++++++++------------
>  1 files changed, 14 insertions(+), 12 deletions(-)

Ah, nice magic!

Well, "warning: 'DMA_DEPRECATED' is deprecated" warning message is a
bit obscure but the developers should notice that they do something
wrong.

Acked-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>


Thanks a lot,
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/include/linux/dma-mapping.h b/include/linux/dma-mapping.h
index 8083b6a..6bf3339 100644
--- a/include/linux/dma-mapping.h
+++ b/include/linux/dma-mapping.h
@@ -63,24 +63,26 @@  struct dma_map_ops {
 
 #define DMA_BIT_MASK(n)	(((n) == 64) ? ~0ULL : ((1ULL<<(n))-1))
 
+typedef u64 DMA_DEPRECATED __deprecated;
+
 /*
  * NOTE: do not use the below macros in new code and do not add new definitions
  * here.
  *
  * Instead, just open-code DMA_BIT_MASK(n) within your driver
  */
-#define DMA_64BIT_MASK	DMA_BIT_MASK(64)
-#define DMA_48BIT_MASK	DMA_BIT_MASK(48)
-#define DMA_47BIT_MASK	DMA_BIT_MASK(47)
-#define DMA_40BIT_MASK	DMA_BIT_MASK(40)
-#define DMA_39BIT_MASK	DMA_BIT_MASK(39)
-#define DMA_35BIT_MASK	DMA_BIT_MASK(35)
-#define DMA_32BIT_MASK	DMA_BIT_MASK(32)
-#define DMA_31BIT_MASK	DMA_BIT_MASK(31)
-#define DMA_30BIT_MASK	DMA_BIT_MASK(30)
-#define DMA_29BIT_MASK	DMA_BIT_MASK(29)
-#define DMA_28BIT_MASK	DMA_BIT_MASK(28)
-#define DMA_24BIT_MASK	DMA_BIT_MASK(24)
+#define DMA_64BIT_MASK	(DMA_DEPRECATED)DMA_BIT_MASK(64)
+#define DMA_48BIT_MASK	(DMA_DEPRECATED)DMA_BIT_MASK(48)
+#define DMA_47BIT_MASK	(DMA_DEPRECATED)DMA_BIT_MASK(47)
+#define DMA_40BIT_MASK	(DMA_DEPRECATED)DMA_BIT_MASK(40)
+#define DMA_39BIT_MASK	(DMA_DEPRECATED)DMA_BIT_MASK(39)
+#define DMA_35BIT_MASK	(DMA_DEPRECATED)DMA_BIT_MASK(35)
+#define DMA_32BIT_MASK	(DMA_DEPRECATED)DMA_BIT_MASK(32)
+#define DMA_31BIT_MASK	(DMA_DEPRECATED)DMA_BIT_MASK(31)
+#define DMA_30BIT_MASK	(DMA_DEPRECATED)DMA_BIT_MASK(30)
+#define DMA_29BIT_MASK	(DMA_DEPRECATED)DMA_BIT_MASK(29)
+#define DMA_28BIT_MASK	(DMA_DEPRECATED)DMA_BIT_MASK(28)
+#define DMA_24BIT_MASK	(DMA_DEPRECATED)DMA_BIT_MASK(24)
 
 #define DMA_MASK_NONE	0x0ULL