Patchwork [U-Boot,3/5] USB: xHCI: Add header for readl/writel functions

login
register
mail settings
Submitter Dan Murphy
Date Aug. 26, 2013, 1:54 p.m.
Message ID <1377525293-31508-4-git-send-email-dmurphy@ti.com>
Download mbox | patch
Permalink /patch/269893/
State Awaiting Upstream
Delegated to: Marek Vasut
Headers show

Comments

Dan Murphy - Aug. 26, 2013, 1:54 p.m.
Add the  asm/io.h header to resolve implicit declaration of
readl/writel

Signed-off-by: Dan Murphy <dmurphy@ti.com>
---
 drivers/usb/host/xhci.h |    2 ++
 1 file changed, 2 insertions(+)
Marek Vasut - Sept. 4, 2013, 2:17 p.m.
Dear Dan Murphy,

> Add the  asm/io.h header to resolve implicit declaration of
> readl/writel
> 
> Signed-off-by: Dan Murphy <dmurphy@ti.com>
> ---
>  drivers/usb/host/xhci.h |    2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/usb/host/xhci.h b/drivers/usb/host/xhci.h
> index 467afe0..91935f0 100644
> --- a/drivers/usb/host/xhci.h
> +++ b/drivers/usb/host/xhci.h
> @@ -27,6 +27,8 @@
>  #ifndef HOST_XHCI_H_
>  #define HOST_XHCI_H_
> 
> +#include <asm/io.h>
> +
>  #include <asm/cache.h>
>  #include <linux/list.h>

I think this can be merged into Vivek's next round?

Best regards,
Marek Vasut
Dan Murphy - Sept. 4, 2013, 3:24 p.m.
Marek
On 09/04/2013 09:17 AM, Marek Vasut wrote:
> Dear Dan Murphy,
>
>> Add the  asm/io.h header to resolve implicit declaration of
>> readl/writel
>>
>> Signed-off-by: Dan Murphy <dmurphy@ti.com>
>> ---
>>  drivers/usb/host/xhci.h |    2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/usb/host/xhci.h b/drivers/usb/host/xhci.h
>> index 467afe0..91935f0 100644
>> --- a/drivers/usb/host/xhci.h
>> +++ b/drivers/usb/host/xhci.h
>> @@ -27,6 +27,8 @@
>>  #ifndef HOST_XHCI_H_
>>  #define HOST_XHCI_H_
>>
>> +#include <asm/io.h>
>> +
>>  #include <asm/cache.h>
>>  #include <linux/list.h>
> I think this can be merged into Vivek's next round?
>
> Best regards,
> Marek Vasut
I hope so this was one of my comments as the asm/io.h showed up in the xhci top level so not sure why it was not included in the global header.

So if v3 has this in xhci.h I am OK with gettin rid of this patch

Dan

Patch

diff --git a/drivers/usb/host/xhci.h b/drivers/usb/host/xhci.h
index 467afe0..91935f0 100644
--- a/drivers/usb/host/xhci.h
+++ b/drivers/usb/host/xhci.h
@@ -27,6 +27,8 @@ 
 #ifndef HOST_XHCI_H_
 #define HOST_XHCI_H_
 
+#include <asm/io.h>
+
 #include <asm/cache.h>
 #include <linux/list.h>