Message ID | 1377434811-25662-1-git-send-email-oliver@freetz.org |
---|---|
State | Changes Requested |
Delegated to: | Tom Rini |
Headers | show |
On Sun, 25 Aug 2013, Oliver Metz wrote: > Signed-off-by: Oliver Metz <oliver@freetz.org> > --- > tools/env/fw_env.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/tools/env/fw_env.c b/tools/env/fw_env.c > index 44607b1..65be5f3 100644 > --- a/tools/env/fw_env.c > +++ b/tools/env/fw_env.c > @@ -1136,6 +1136,9 @@ int fw_env_open(void) > } else if (DEVTYPE(dev_current) == MTD_UBIVOLUME && > DEVTYPE(!dev_current) == MTD_UBIVOLUME) { > environment.flag_scheme = FLAG_INCREMENTAL; > + } else if (DEVTYPE(dev_current) == MTD_ABSENT && > + DEVTYPE(!dev_current) == MTD_ABSENT) { > + environment.flag_scheme = FLAG_INCREMENTAL; > } else { > fprintf (stderr, "Incompatible flash types!\n"); > return -1; pedantically, it's "redundant", not "redundand". and it might be useful to add some commentary in the sample fw_env.config file that explains this new feature, as the patch is clearly not adding any documentation. rday
diff --git a/tools/env/fw_env.c b/tools/env/fw_env.c index 44607b1..65be5f3 100644 --- a/tools/env/fw_env.c +++ b/tools/env/fw_env.c @@ -1136,6 +1136,9 @@ int fw_env_open(void) } else if (DEVTYPE(dev_current) == MTD_UBIVOLUME && DEVTYPE(!dev_current) == MTD_UBIVOLUME) { environment.flag_scheme = FLAG_INCREMENTAL; + } else if (DEVTYPE(dev_current) == MTD_ABSENT && + DEVTYPE(!dev_current) == MTD_ABSENT) { + environment.flag_scheme = FLAG_INCREMENTAL; } else { fprintf (stderr, "Incompatible flash types!\n"); return -1;
Signed-off-by: Oliver Metz <oliver@freetz.org> --- tools/env/fw_env.c | 3 +++ 1 file changed, 3 insertions(+)