Patchwork [U-Boot,1/2] fw_env: add redundand env support for MTD_ABSENT

login
register
mail settings
Submitter Oliver Metz
Date Aug. 25, 2013, 12:46 p.m.
Message ID <1377434811-25662-1-git-send-email-oliver@freetz.org>
Download mbox | patch
Permalink /patch/269864/
State Changes Requested
Delegated to: Tom Rini
Headers show

Comments

Oliver Metz - Aug. 25, 2013, 12:46 p.m.
Signed-off-by: Oliver Metz <oliver@freetz.org>
---
 tools/env/fw_env.c | 3 +++
 1 file changed, 3 insertions(+)
Robert P. J. Day - Aug. 26, 2013, 2:25 p.m.
On Sun, 25 Aug 2013, Oliver Metz wrote:

> Signed-off-by: Oliver Metz <oliver@freetz.org>
> ---
>  tools/env/fw_env.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/tools/env/fw_env.c b/tools/env/fw_env.c
> index 44607b1..65be5f3 100644
> --- a/tools/env/fw_env.c
> +++ b/tools/env/fw_env.c
> @@ -1136,6 +1136,9 @@ int fw_env_open(void)
>  		} else if (DEVTYPE(dev_current) == MTD_UBIVOLUME &&
>  			   DEVTYPE(!dev_current) == MTD_UBIVOLUME) {
>  			environment.flag_scheme = FLAG_INCREMENTAL;
> +		} else if (DEVTYPE(dev_current) == MTD_ABSENT &&
> +			   DEVTYPE(!dev_current) == MTD_ABSENT) {
> +			environment.flag_scheme = FLAG_INCREMENTAL;
>  		} else {
>  			fprintf (stderr, "Incompatible flash types!\n");
>  			return -1;

  pedantically, it's "redundant", not "redundand". and it might be
useful to add some commentary in the sample fw_env.config file that
explains this new feature, as the patch is clearly not adding any
documentation.

rday

Patch

diff --git a/tools/env/fw_env.c b/tools/env/fw_env.c
index 44607b1..65be5f3 100644
--- a/tools/env/fw_env.c
+++ b/tools/env/fw_env.c
@@ -1136,6 +1136,9 @@  int fw_env_open(void)
 		} else if (DEVTYPE(dev_current) == MTD_UBIVOLUME &&
 			   DEVTYPE(!dev_current) == MTD_UBIVOLUME) {
 			environment.flag_scheme = FLAG_INCREMENTAL;
+		} else if (DEVTYPE(dev_current) == MTD_ABSENT &&
+			   DEVTYPE(!dev_current) == MTD_ABSENT) {
+			environment.flag_scheme = FLAG_INCREMENTAL;
 		} else {
 			fprintf (stderr, "Incompatible flash types!\n");
 			return -1;