Patchwork [GIT,PULL,for,v3.12] pull request from pxa git tree on mmp-irq

login
register
mail settings
Submitter Haojian Zhuang
Date Aug. 24, 2013, 1:44 p.m.
Message ID <CAN1soZwOH0hifZPgJp7btfbT8zn9OXHvy-+2zYqH3Mob4NAuFQ@mail.gmail.com>
Download mbox
Permalink /patch/269637/
State New
Headers show

Pull-request

git://git.kernel.org/pub/scm/linux/kernel/git/hzhuang1/linux.git tags/mmp-irq

Comments

Haojian Zhuang - Aug. 24, 2013, 1:44 p.m.
Hi Arnd, Olof & Kevin,

Please pull mmp-irq branch from pxa git tree. It moved irq driver from
arch-mmp directory to irqchip directory, since it's used to support
multiplatform.

Best Regards
Haojian

The following changes since commit ad81f0545ef01ea651886dddac4bef6cec930092:

  Linux 3.11-rc1 (2013-07-14 15:18:27 -0700)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/hzhuang1/linux.git tags/mmp-irq

for you to fetch changes up to 942f42214d693f98b6165d0202d21291f95bc37d:

  irqchip: mmp: avoid to include irqs head file (2013-08-24 17:45:47 +0800)

----------------------------------------------------------------
move irq driver out of mach-mmp to support multiplatform

----------------------------------------------------------------
Haojian Zhuang (4):
      irqchip: move mmp irq driver
      irqchip: mmp: support irqchip
      ARM: mmp: avoid to include head file in mach-mmp
      irqchip: mmp: avoid to include irqs head file

 arch/arm/Kconfig                                     |   1 +
 arch/arm/mach-mmp/Makefile                           |   2 +-
 arch/arm/mach-mmp/common.h                           |   1 -
 arch/arm/mach-mmp/include/mach/entry-macro.S         |  26 -------
 arch/arm/mach-mmp/include/mach/pxa168.h              |   1 +
 arch/arm/mach-mmp/include/mach/pxa910.h              |   1 +
 arch/arm/mach-mmp/mmp-dt.c                           |   8 +--
 arch/arm/mach-mmp/mmp2-dt.c                          |   8 +--
 arch/arm/mach-mmp/mmp2.c                             |   6 ++
 arch/arm/mach-mmp/pxa910.c                           |   7 ++
 drivers/irqchip/Makefile                             |   1 +
 arch/arm/mach-mmp/irq.c => drivers/irqchip/irq-mmp.c | 338
+++++++++++++++++++++++++++++++++++++++++++++++++----------------------------------------
 include/linux/irqchip/mmp.h                          |   6 ++
 13 files changed, 211 insertions(+), 195 deletions(-)
 delete mode 100644 arch/arm/mach-mmp/include/mach/entry-macro.S
 rename arch/arm/mach-mmp/irq.c => drivers/irqchip/irq-mmp.c (63%)
 create mode 100644 include/linux/irqchip/mmp.h
Daniel Drake - Aug. 24, 2013, 2:12 p.m.
On Sat, Aug 24, 2013 at 7:44 AM, Haojian Zhuang
<haojian.zhuang@gmail.com> wrote:
> Hi Arnd, Olof & Kevin,
>
> Please pull mmp-irq branch from pxa git tree. It moved irq driver from
> arch-mmp directory to irqchip directory, since it's used to support
> multiplatform.

Thanks for continuing the work on this.

It looks like the final patch is missing a response from the review from Arnd.
http://article.gmane.org/gmane.linux.ports.arm.kernel/255492

Looks good otherwise.

Daniel
Haojian Zhuang - Aug. 24, 2013, 2:35 p.m.
On Sat, Aug 24, 2013 at 10:12 PM, Daniel Drake <dsd@laptop.org> wrote:
> On Sat, Aug 24, 2013 at 7:44 AM, Haojian Zhuang
> <haojian.zhuang@gmail.com> wrote:
>> Hi Arnd, Olof & Kevin,
>>
>> Please pull mmp-irq branch from pxa git tree. It moved irq driver from
>> arch-mmp directory to irqchip directory, since it's used to support
>> multiplatform.
>
> Thanks for continuing the work on this.
>
> It looks like the final patch is missing a response from the review from Arnd.
> http://article.gmane.org/gmane.linux.ports.arm.kernel/255492
>
> Looks good otherwise.
>
> Daniel


>I'd suggest passing IRQ_MMP2_PMIC_BASE and the other constants from the caller
>and changing the prototype accordingly so you can do

>mmp2_init_icu(0, IRQ_MMP2_PMIC_BASE, IRQ_MMP2_RTC_BASE, IRQ_MMP2_KEYPAD_BASE,
>IRQ_MMP2_TWSI_BASE, IRQ_MMP2_MISC_BASE, IRQ_MMP2_MIPI_HSI1_BASE,
>IRQ_MMP2_MIPI_HSI0_BASE);

I'm sorry that I forget to response the mail. I don't want to use any
irq macro define in
irq-mmp driver at this time.

1. Those IRQ macro are defined in <mach/irqs.h>. And they're widely
used in mach-mmp
directory. In order to support multiplatform, I avoid to include this
head file in irq-mmp driver.
I don't want to use any macro in this head file. Otherwise, it'll
break my effort.

2. I also don't want to define a function with too much parameters.
It's not easy to read.

Best Regards
Haojian
Olof Johansson - Aug. 29, 2013, 8:22 p.m.
On Sat, Aug 24, 2013 at 09:44:33PM +0800, Haojian Zhuang wrote:
> Hi Arnd, Olof & Kevin,
> 
> Please pull mmp-irq branch from pxa git tree. It moved irq driver from
> arch-mmp directory to irqchip directory, since it's used to support
> multiplatform.

I've pulled this into late/all, to be sent up during the later part of the mere
window.


-Olof