From patchwork Sat Aug 24 01:06:06 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mike Stump X-Patchwork-Id: 269597 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "localhost", Issuer "www.qmailtoaster.com" (not verified)) by ozlabs.org (Postfix) with ESMTPS id 372022C0082 for ; Sat, 24 Aug 2013 11:06:16 +1000 (EST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :content-type:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; q=dns; s= default; b=eks2F8Sxk/D28NaFPJRCBwsSVHU+yj4z7laayGcumjtZ4O8IKpl+l QW3dwCyZvvQR8aiwbPFimh28Y7ABXWkPn6voOkHyJX0AXe9le9u5CVoYcPv8/F3D T8tioMIENtDT5VoIrxkYPBfGssnNhG9kuHeDYt4n0FfkJZ0BI3Vf/E= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :content-type:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; s=default; bh=JAtKrQFCi8YD988rFi6nvzZ7o8o=; b=ZVU3Vci5JJON3pXUsMSqmkhP3bRK 3asTHQbC2lD7syNcuw1r+EOvyQD9MmwNicJ3NQI/d4KQUk7JrWMRQN7NA0wZxfUR Ji0hcpF63yMEXqYBBXwqQSVuK8MsJYXflSiUKJ0oYOXdnnQTX2FwKpXqM+H5almb 408poStC28HIXgU= Received: (qmail 5724 invoked by alias); 24 Aug 2013 01:06:10 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 5706 invoked by uid 89); 24 Aug 2013 01:06:09 -0000 X-Spam-SWARE-Status: No, score=-4.2 required=5.0 tests=AWL, BAYES_00, FREEMAIL_FROM, KHOP_THREADED, RCVD_IN_DNSWL_NONE, RCVD_IN_HOSTKARMA_YE, RP_MATCHES_RCVD, SPF_PASS autolearn=ham version=3.3.2 Received: from qmta13.emeryville.ca.mail.comcast.net (HELO qmta13.emeryville.ca.mail.comcast.net) (76.96.27.243) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Sat, 24 Aug 2013 01:06:09 +0000 Received: from omta23.emeryville.ca.mail.comcast.net ([76.96.30.90]) by qmta13.emeryville.ca.mail.comcast.net with comcast id GQk21m0031wfjNsADR67iQ; Sat, 24 Aug 2013 01:06:07 +0000 Received: from up.mrs.kithrup.com ([24.4.193.8]) by omta23.emeryville.ca.mail.comcast.net with comcast id GR661m0190BKwT48jR67ur; Sat, 24 Aug 2013 01:06:07 +0000 Mime-Version: 1.0 (Mac OS X Mail 6.5 \(1508\)) Subject: Re: wide-int branch now up for public comment and review From: Mike Stump In-Reply-To: <87ppt4e9hg.fsf@talisman.default> Date: Fri, 23 Aug 2013 18:06:06 -0700 Cc: Kenneth Zadeck , rguenther@suse.de, gcc-patches , r.sandiford@uk.ibm.com Message-Id: References: <520A9DCC.6080609@naturalbridge.com> <87ppt4e9hg.fsf@talisman.default> To: Richard Sandiford On Aug 23, 2013, at 8:02 AM, Richard Sandiford wrote: >> #define addr_max_bitsize (64) >> #define addr_max_precision \ > > These should either be lower-case C++ constants or upper-case macros. Fixed: diff --git a/gcc/wide-int.h b/gcc/wide-int.h index 9ccdf7c..b40962c 100644 --- a/gcc/wide-int.h +++ b/gcc/wide-int.h @@ -247,15 +247,15 @@ along with GCC; see the file COPYING3. If not see on any platform is 64 bits. When that changes, then it is likely that a target hook should be defined so that targets can make this value larger for those targets. */ -#define addr_max_bitsize (64) +const int addr_max_bitsize = 64; /* This is the internal precision used when doing any address arithmetic. The '4' is really 3 + 1. Three of the bits are for the number of extra bits needed to do bit addresses and single bit is allow everything to be signed without loosing any precision. Then everything is rounded up to the next HWI for efficiency. */ -#define addr_max_precision \ - ((addr_max_bitsize + 4 + HOST_BITS_PER_WIDE_INT - 1) & ~(HOST_BITS_PER_WIDE_INT - 1)) +const int addr_max_precision + = ((addr_max_bitsize + 4 + HOST_BITS_PER_WIDE_INT - 1) & ~(HOST_BITS_PER_WIDE_INT - 1)); enum ShiftOp { NONE,